Nyancatpig / Cultural-Delights-1.18.2

A Farmer's Delight addon that adds food systems from around the world.
MIT License
1 stars 5 forks source link

Serene Seasons Compat #23

Open theDaleighChronicle opened 1 year ago

theDaleighChronicle commented 1 year ago

Hi, I'm trying to create a datapack to add compatibility for Serene Seasons, but when adding the Corn to the Autumn season tag, nothing changes in game. I am directly referencing the blockstate, model, and item names from the directory.

Nyancatpig commented 1 year ago

What changes ingame? Does something break?

theDaleighChronicle commented 1 year ago

Sorry, that was a mistype. I meant that nothing changes in game. It doesn't add the tag, nor add the seasonal fertility mechanics. The corn just straight up ignores the tag.

Nyancatpig commented 1 year ago

That is odd I don't know what the problem would be, you may want to ask the people behind Serene Seasons

theDaleighChronicle commented 1 year ago

They said that Serene Seasons uses the encoded Minecraft growth mechanics. Does the corn crop in cultural delights change anything about the vanilla growth mechanics?

Nyancatpig commented 1 year ago

Well it implements BonemealableBlock and extends BushBlock, which I would assume is covered by SS

MarioSMB commented 1 year ago

It has been a while since I touched this stuff, but I believe we had corn working correctly with seasons. If it helps, this is what I had in my autumn_crops.json file:

    {"id":"culturaldelights:corn","required":false},
    {"id":"culturaldelights:corn_upper","required":false},