search

NyaomiDEV / Ampersand

GNU Affero General Public License v3.0
10 stars 2 forks source link

Added romanian translation #13

Closed mih44 closed 1 month ago

mih44 commented 1 month ago

Hi, I've added the romanian translation and also changed the code in i18n.ts to enable it. The language switcher doesn't seem to work correctly but I have not touched that.

NyaomiDEV commented 1 month ago

There are missing strings, as you've probably translated up to some point in time.

I'll be happy to merge this PR once this translation matches 1:1 with the current English translation.

mih44 commented 1 month ago

Done, I think that's all, if I missed a file please tell me.

NyaomiDEV commented 1 month ago

Done, I think that's all, if I missed a file please tell me.

there have been some changes inside options.json for sure; then again, please review each file as I've been really rushing development and I forgot what's changed (also I don't know at which point in time you forked)

mih44 commented 1 month ago

I think my editor might've added an empty line at the end of some files, sorry about that.

as mentioned in the commit message - regarding tagManagement.edit.actions, if the key is named desc_other it doesn't get picked up by the web interface, but if it's called just desc it does get picked up.

NyaomiDEV commented 1 month ago

as mentioned in the commit message - regarding tagManagement.edit.actions, if the key is named desc_other it doesn't get picked up by the web interface, but if it's called just desc it does get picked up.

Please revert desc to desc_other. If it won't pick that up, we have to fix the actual cause.

Ittihadyya commented 1 month ago

as mentioned in the commit message - regarding tagManagement.edit.actions, if the key is named desc_other it doesn't get picked up by the web interface, but if it's called just desc it does get picked up.

Please revert desc to desc_other. If it won't pick that up, we have to fix the actual cause.

Done.

NyaomiDEV commented 1 month ago

... i fucked up

Ittihadyya commented 1 month ago

... i fucked up

I noticed haha

NyaomiDEV commented 1 month ago

whatever, it's in main now

look for it at github pages! and thanks!

Ittihadyya commented 1 month ago

whatever, it's in main now

look for it at github pages! and thanks!

It works! No problem, glad to be of help!