search

NyaomiDEV / Sunamu

Show your currently playing song in a stylish way!
Mozilla Public License 2.0
404 stars 15 forks source link

Support for other lyric proviers? #12

Closed Seb3thehacker closed 2 years ago

Seb3thehacker commented 2 years ago

Having the option to choose other providers would be great. I've run in to handful of songs so far that have no lyrics displayed because of NetEase not having them.

NyaomiDEV commented 2 years ago

I'd love to add more providers, but I don't know of any other providers that offer synchronized lyrics.

Keep in mind that by installing the Musixmatch App alongside Sunamu, it will be able to pull in lyrics from MXM too!

Seb3thehacker commented 2 years ago

https://github.com/spotDL/spotify-downloader uses genius and musixmatch. Maybe support for genius would work?

NyaomiDEV commented 2 years ago

But I added Genius! Maybe it broke...

NyaomiDEV commented 2 years ago

@Seb3thehacker

Commit 9fe255b217018dea33723ac2c95b2580d7cd5b98 democratizes Musixmatch by bringing it in without parasiting on the official app. Sunamu is now able to request a token straight to the API, and therefore you should see it being used more often (on the git package or if building yourself)

Additionally, commit ed0d426c4bba070071ad02d831b20ae9dab2d9b5 fixes the Genius provider's scraping logic so it is aligned with what spotDL does.