NyaomiDEV / Sunamu

Show your currently playing song in a stylish way!
Mozilla Public License 2.0
403 stars 14 forks source link

Support Simplified Chinese Translation #48

Closed aimerneige closed 2 years ago

aimerneige commented 2 years ago

As in title.

Jsut a little work. I did not do build test.

NyaomiDEV commented 2 years ago

if you tested it in the test environment then it is safe to merge; if the translation is untested I won't merge it

aimerneige commented 2 years ago

Got it. I will do the test.

aimerneige commented 2 years ago

I build a deb package and install it on a clean installed ubuntu 22.04 kvm virtual machine. It works fine.

Screenshot from 2022-09-02 22-19-28 Screenshot from 2022-09-02 22-20-06

NyaomiDEV commented 2 years ago

there is a test that was not conducted; does sunamu use simplified chinese in a machine or vm which is configured to use simplified chinese? I mean without uncommenting the language in the config file

aimerneige commented 2 years ago

I recoverd vm's snapshot and set the languge to Chinese. Then I install Sunamu, without touching the config file. It display English.

截图 2022-09-03 12-21-44

aimerneige commented 2 years ago

When I try to comment the language config, sunamu just write a newline into it.

    language: "en",
NyaomiDEV commented 2 years ago

This is not supposed to happen. Can you do language: "" for now?

aimerneige commented 2 years ago

This is not supposed to happen. Can you do language: "" for now?

I try this and it works

截图 2022-09-04 01-34-21