NyaomiDEV / Sunamu

Show your currently playing song in a stylish way!
Mozilla Public License 2.0
403 stars 14 forks source link

Check ID3/lrc file for lyrics #55

Closed hannahswain closed 1 year ago

hannahswain commented 1 year ago

It's great how many different lyrics Sunamu can find! However, some of them just don't exist (music too new/too niche) or the syncing is wrong. I like adding my own synced lyrics to the ID3/Vorbis tag so that they are correct.

Would you consider checking the file tag, then for a .lrc file, and then checking other online sources?

NyaomiDEV commented 1 year ago

Well, if you're on Linux and your media player supports it, your lyric tag already gets read by Sunamu (it just won't read it as a LRC formatted tag, for now).

However, giving Sunamu access to the entire file system is problematic on Flatpak builds, so I chose to not read any sparse .LRC files at all and this will not change as I don't want people to have to use Flatseal to restrict the scope of Sunamu or mess with its permissions on Linux.

On Windows, given the limitations of the SMTC API, what you ask is essentially impossible.

--

The only thing I could do for you is to interpret the metadata, when it gets passed to Sunamu correctly, as a LRC based on some "heuristics" I might come up with.

hannahswain commented 1 year ago

Thanks for that background!

I think my situation may be an edge-case then:

I tested yesterday and Sunamu was not using my lyrics - I could tell because they weren't synced while I could see the synced lyrics correctly in another app (Symfonium on Android).

I wanted to make sure it was on the radar in case anyone else came across it. Thanks again!

NyaomiDEV commented 1 year ago

Sonixd I believe is not fully compliant and it won't pass lyrics to the MPRIS API.

This said, Sunamu @ git already supports provider re-ordering so that you can put your metadata in front of other services. The part which is NOT there is the LRC interpretation.

NyaomiDEV commented 1 year ago

and there you have it, something something

hannahswain commented 1 year ago

Lovely, thank you!