search

NyasakiAT / NotesExtension

A handy chrome extension to quickly save portions of webpages and other stuff!
4 stars 3 forks source link

Protected share button from spamming #17

Closed theGeekyLad closed 3 years ago

theGeekyLad commented 3 years ago

Great project! I'd have probably not come across it hadn't it been for Hacktoberfest. 😄

Spotted a minor bug when I started actively using it; on slow networks the delay between clicking the "share" button and the opening of a new tab is significant, during which, spamming the button multiple times opens the new tab as many times.

Before Fix

notes-bug

I clicked / spammed the "share" button 3 times and the new tab is opened thrice.

After Fix

notes-bug-fix

The button is disabled when the fetch inside share(id, data) is being processed and a visual cue is shown to the user by changing the button text.

NyasakiAT commented 3 years ago

Hey, never thought of that, but its a great addition :) Thanks a lot for the PR! 👍