search

Nycto / PicoModal

A small, self-contained JavaScript modal library. Plain, vanilla JS.
MIT License
241 stars 42 forks source link

Exposed interface for "build" #15

Closed mikob closed 9 years ago

mikob commented 9 years ago

Useful when building the dom for the modal is expensive or it needs to be prebuilt before displaying for any other reason (eg. dynamic compilation). Updated README.md to reflect this.

Nycto commented 9 years ago

Thanks for the contribution! I'll try to take a look at this within the next couple of days. I think the "display" changes are backwards compatible, but I want to review the logic to be sure.

Nycto commented 9 years ago

Thanks for the contribution! As a heads up, I went back and forth on the naming here; I wound up with buildDom instead of just build, so you may need to adjust your dependent code accordingly.

Cheers