search

Nyholm / psr7-server

Helper classes to use any PSR7 implementation as your main request and response
MIT License
90 stars 21 forks source link

added missing doc tags #22

Closed persianphilosopher closed 6 years ago

persianphilosopher commented 6 years ago

Very small changes to the PHPDocs, mostly @return tags were missing.

Nyholm commented 6 years ago

Thank you for this PR. This is actually a decision we and most open source libraries are doing now. If there is PHP7 return type hint or other type hints we do not "duplicate" that information in a doc block. It is only okey to have a doc block if brings any additional information.

persianphilosopher commented 6 years ago

Makes perfect sense. Thank you for the explanation