Issue #29: Update URI Scheme detection - Githubissues

Nyholm / psr7-server

Helper classes to use any PSR7 implementation as your main request and response

MIT License

91 stars 21 forks source link

Issue #29: Update URI Scheme detection #32

Closed drupol closed 5 years ago

drupol commented 5 years ago

Related to #29

There was an issue with the tests, I also fixed it.

When the key 'HTTPS' is set to '1', it means that it should be in HTTPS, but in the tests it's not taken in account, see this line: https://github.com/Nyholm/psr7-server/blob/master/tests/ServerRequestCreatorTest.php#L347 Then this line: https://github.com/Nyholm/psr7-server/blob/master/tests/ServerRequestCreatorTest.php#L393

My PR fixes this at a glance.

Nyholm commented 5 years ago

Thank you