Nyholm / psr7-server

Helper classes to use any PSR7 implementation as your main request and response
MIT License
90 stars 21 forks source link

Added support for numeric headers #36

Closed nickdnk closed 4 years ago

nickdnk commented 4 years ago

Because this whole numeric header thing involves both psr7 and psr7-server, I think we need to make this change to keep everything in line.

https://github.com/Nyholm/psr7/pull/149 needs to be merged into psr7 first, and used in this PR for the tests to pass. I created the PR to demonstrate this.

Zegnat commented 4 years ago

All checks pass for me locally, so this looks mergeable now! @Nyholm should we merge this or do you want to try and trigger Travis first?

nickdnk commented 4 years ago

Do I need to do anything here?

Zegnat commented 4 years ago

@nickdnk I don’t think so. I have been busy, and I think @Nyholm is too. But I’ll have a look this weekend, and see if I can just manually merge even if Travis hasn’t done a rerun. Would be nice to get this merged and released, as you said!

nickdnk commented 4 years ago

Tests pass now at least. I upped the version for psr7 to ^1.3 in composer.json.