search

Nyholm / psr7-server

Helper classes to use any PSR7 implementation as your main request and response
MIT License
90 stars 21 forks source link

Prepare for 1.0 #39

Closed Nyholm closed 4 years ago

Nyholm commented 4 years ago

This will fix #11

This package has been fairly stable for a long while.

Zegnat commented 4 years ago

Seems fine to me. It has been stable to a while now. Wondering if we want to clear the other 2 PRs before pushing 1.0?

Zegnat commented 4 years ago

I have just rebased #27 on the latest master. It introduces a minor parameter widening on the methods ($post goes from array to array|null). Would love to be able to land that before version 1.0. As I think it is the only thing (from both PRs and issues) that actually signifies a method signature change.

Nyholm commented 4 years ago

PR is rebased and the BC break is documented

Nyholm commented 4 years ago

I made another small change to this PR. What do you think?

Zegnat commented 4 years ago

Aah, I must have missed that one. If I read this correctly, this is to allow the user to pass in null when they want to specify $files and $body? Makes a lot of sense to me!

Nyholm commented 4 years ago

Thank you