I was running the tests for this package and had several tests failing.
I dug into it and discovered that the test examples provide error codes for uploaded files as string type, but they should be int types. The strict comparison introduced in version 1.0.2 didn't recognize these error codes as intended.
Changing the error codes to the proper references in the test fixed the test cases that were failing.
I was puzzled that the build was passing on travis (the change causing the tests to fail was introduced in version 1.0.2). I noticed that when I ran PHPUnit locally it reported 30 tests passing, but when I checked the build log on travis, it only reported 29 passing tests. So it seems travis was ignoring the failing tests. But I couldn't see any reason why it would skip that, so I'm still sort of puzzled as to how travis ended up passing the build.
I also migrated the phpunit.xml.dist, while I was here. It was throwing a warning during tests.
I was running the tests for this package and had several tests failing.
I dug into it and discovered that the test examples provide error codes for uploaded files as string type, but they should be int types. The strict comparison introduced in version 1.0.2 didn't recognize these error codes as intended.
Changing the error codes to the proper references in the test fixed the test cases that were failing.
I was puzzled that the build was passing on travis (the change causing the tests to fail was introduced in version 1.0.2). I noticed that when I ran PHPUnit locally it reported 30 tests passing, but when I checked the build log on travis, it only reported 29 passing tests. So it seems travis was ignoring the failing tests. But I couldn't see any reason why it would skip that, so I'm still sort of puzzled as to how travis ended up passing the build.
I also migrated the phpunit.xml.dist, while I was here. It was throwing a warning during tests.