search

Nyholm / psr7

A super lightweight PSR-7 implementation
MIT License
1.16k stars 75 forks source link

Add return types to HttplugFactory #188

Closed ostrolucky closed 2 years ago

ostrolucky commented 2 years ago

This is needed to do now because symfony/error-handler triggers deprecation notices such these

  1x: Method "Http\Message\RequestFactory::createRequest()" might add "RequestInterface" as a native return type declaration in the future. Do the same in implementation "Nyholm\Psr7\Factory\HttplugFactory" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in DiscoveredClientsTest::testForcedDiscovery from Http\HttplugBundle\Tests\Functional

  1x: Method "Http\Message\ResponseFactory::createResponse()" might add "ResponseInterface" as a native return type declaration in the future. Do the same in implementation "Nyholm\Psr7\Factory\HttplugFactory" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in DiscoveredClientsTest::testForcedDiscovery from Http\HttplugBundle\Tests\Functional

  1x: Method "Http\Message\StreamFactory::createStream()" might add "StreamInterface" as a native return type declaration in the future. Do the same in implementation "Nyholm\Psr7\Factory\HttplugFactory" now to avoid errors or add an explicit @return annotation to suppress this message.
    1x in DiscoveredClientsTest::testForcedDiscovery from Http\HttplugBundle\Tests\Functional
ostrolucky commented 2 years ago

can you merge & tag? :) looks like i have rights in httplugbundle only

Nyholm commented 2 years ago

Thank you for this contribution.

acirtautas commented 2 years ago

Hi @Nyholm and @ostrolucky, thank you for your great work! As the change has been merged it would be good to tag an release it.

Nyholm commented 2 years ago

Yes, tagging now