Closed luisfn closed 2 years ago
No sure how to fix the BC, as the class already have some methods using static as return types, should be ok for the targeted PHP versions. WDYT?
Thank you.
We can solve this in different ways, right? Static
will help the very brave people that extend this class even though it is marked as @final
.
Could we be a little less forward and do #ReturnTypeWillChange
?
These deprecation messages triggered from symfony/error-handler. I want just to mention - if will be used way with "#[ReturnTypeWillChange]" (and no return types), it won't get rid from deprecations - phpdoc with types will be needed too.
Okey. Could we add php doc too then?
To get rid PHP8.1 and symfony/error-handler deprecations it should be one of these: 1) return types 2) phpdoc + attribute
Okey. Thank you. I sugget to do number 2 (phpdoc + attribute). That will also make sure the BC job is not failing and we are sure to not have any side effects
any progress? @Nyholm
Oh. I missed the PR. I think it looks all good. I'll look now.
Just added return types to ServerRequest class where they were not specified. The goal is to fixes deprecation messages on PHP8.1 as the ones below:
Please let me know if adjustments are needed
This will fix #195