Closed nicolas-grekas closed 1 year ago
nicolas-grekas
commented
1 year ago I think we should instead cover those edge cases in https://github.com/php-http/psr7-integration-tests/, and encourage mainstream implementations to adopt this test suite. On this we can have a leverage as a community. Not on the FIG.
dbu
commented
1 year ago About the BC break, there can't be any, because the resulting URLs are invalid right now, so this is only a bugfix (as discussed on php-http/discovery#222)
in the discussion in https://github.com/php-fig/fig-standards/pull/1298 it was mentioned that encoding immediately changes what is returned in getUserInfo. that said, as that method concatenates username and password, separated by :, if somebody was going that route they would still have had a bug when the password contains a :...
i guess the changelog is good enough in case somebody hits that edge case. i think my concern is more about xkcd than anything relevant... so lets go.
nicolas-grekas
commented
1 year ago Thanks for jumping into the topic and for the reviews!
Nyholm
commented
1 year ago Thank you
nicolas-grekas
commented
1 year ago Thanks for merging and tagging!
dbu
commented
1 year ago
I have zero confidence in the speed of anything when the FIG is involved (except maybe for negative speed ;) ) About the BC break, there can't be any, because the resulting URLs are invalid right now, so this is only a bugfix (as discussed on https://github.com/php-http/discovery/issues/222)