Closed simPod closed 1 year ago
Hm, let's test it.
There are indeed some type changes required but I believe the v2 support won't be possible now since old php versions are allowed.
We should bump to PHP >=7.2 also
If that's okay with you I've opened >=7.2 PR
here https://github.com/Nyholm/psr7/pull/226
Also, I think we cannot have support for both v1 and v2 since methods with typed arguments are not backward compatible.
methods with typed arguments are not backward compatible
because of the behavior change when passing incompatible types, or?
Because changing e.g.
- public function withProtocolVersion($version): self
+ public function withProtocolVersion(string $version): self
is required and compatible with v2 but not compatible with v1
It's compatible with 1.1, so we could just bump to ^1.1|^2.0, no?
Test suite is being adapted here https://github.com/php-http/psr7-integration-tests/pull/68
Closing in favor of #234, thanks for pushing for this.
In the CI:
So that's not enough.
Also, is this lib really compatible with v2? Doesn't it miss some return types?