[PHP 8.4] Fixes for implicit nullability deprecation

Nyholm / psr7

A super lightweight PSR-7 implementation

MIT License

1.15k stars 75 forks source link

[PHP 8.4] Fixes for implicit nullability deprecation #255

Closed Ayesh closed 4 months ago

Ayesh commented 5 months ago

Fixes all issues that emits a deprecation notice on PHP 8.4.

See:

RFC
PHP 8.4: Implicitly nullable parameter declarations deprecated

nicolas-grekas commented 4 months ago

@Zegnat @Nyholm sorry for the ping: could you please consider merging this PR ASAP? That'd help on Symfony's side! :pray:

Zegnat commented 4 months ago

No worries and thanks for the ping @nicolas-grekas! Answering from my phone now, day job ahead (CEST), but I can commit some time as soon as I get to my home machine if nobody beats me to it.

nicolas-grekas commented 4 months ago

Ah, I just realized I do have merge rights! :sweat_smile:

nicolas-grekas commented 4 months ago

Merged (I'll let you do the releasing, it's not a hurry on Symfony's side, we run dev deps :))