Nyx0uf / qlImageSize

QuickLook and Spotlight plugins to display the dimensions, size and DPI of an image in the title bar instead of the filename. Also preview some unsupported formats like WebP & bpg.
MIT License
1.19k stars 66 forks source link

Image size can't be seen on small images #3

Closed andoro closed 10 years ago

andoro commented 11 years ago

issue Dear Nyx0uf!

I think it's a great plugin. I'm a webdeveloper and I work with lots of small images every day. My question is that is it possible to show image dimensions below the image? If the image is small, the QL window is also small so I can't see the dimension :( The name of the image is not important at all for me, it would be also good if you change the order of these.

Thx a lot!

Nyx0uf commented 11 years ago

I can easily change the display order in the window title.

Showing the dimension under the image is also totally doable but require more code. I'll do this monday or tuesday.

Nyx0uf commented 11 years ago

Ok, made a quick prototype, you can download it here : http://repo.whine.fr/qlImageSize.qlgenerator-TEST.zip

Remove the old plugin and use this one, then probably need to do a qlmanage -r in the terminal.

Tell me if it sounds good

andoro commented 11 years ago

small large

Thx for quick coding :) It works on a medium picture. I've uploaded two pictures. A very small and a larger one. Problem is the same, the font size of the text depends on the size of the picture. Maybe you should write the dimensions to a new layer which is fixed size? Or make a footer and write it there?

Thx in advance!

Nyx0uf commented 11 years ago

Ok, I updated the beta : http://repo.whine.fr/qlImageSize.qlgenerator-TEST.zip

It should work better.

Sorry for taking so much time;

andoro commented 11 years ago

Thank you, it's much better now! :)

The previous problem persist only on large images. Maybe would be the best not to render the dimensions on to the image.

2013.07.09. dátummal, 15:13 idõpontban Nyx0uf notifications@github.com írta:

Ok, I updated the beta : http://repo.whine.fr/qlImageSize.qlgenerator-TEST.zip

It should work better.

Sorry for taking so much time;

— Reply to this email directly or view it on GitHub.

Nyx0uf commented 11 years ago

I tried on a 27" iMac so I didn't see the problem..

I'll see what I can do, seems a little more tricky though

EDIT: Looks like QL automatically resize the image if it's bigger than the screen, that's why the text appears smaller

Nyx0uf commented 11 years ago

Ok, this problem is quite tricky as getting the screen size inside a QuickLook plugin seems to be impossible.

A solution could be to force the size of the QL window, but it will be a bit weird on big resolutions screens like iMac 27" or retina Macs.

Also updated the titlebar info, it now display infos like this: WIDTHxHEIGHT | filename | filesize

http://repo.whine.fr/qlImageSize.qlgenerator-TEST.zip

andoro commented 11 years ago

Hello!

Thx for your work! For me, this version is working the best on a 15 inch Macbook Pro...

2013.07.12. dátummal, 11:58 idõpontban Nyx0uf notifications@github.com írta:

Ok, this problem is quite tricky as getting the screen size inside a QuickLook plugin seems to be impossible.

A solution could be to force the size of the QL window, but it will be a bit weird on big resolutions screens like iMac 27" or retina Macs.

Also updated the titlebar info, it now display infos like this: WIDTHxHEIGHT | filename | filesize

http://repo.whine.fr/qlImageSize.qlgenerator-TEST.zip

— Reply to this email directly or view it on GitHub.

Nyx0uf commented 11 years ago

Ok great, I'm gonna merge and upload this version.

I'm letting this issue opened since there is still a problem with big images

Nyx0uf commented 10 years ago

Since the size is displayed before everything in the titlebar I believe there's no longer a problem.