NyxCode / ormx

bringing orm-like features to sqlx
MIT License
287 stars 32 forks source link

Add a mechanism to describe partial updates #29

Open Punie opened 2 years ago

Punie commented 2 years ago

I think it would be valuable to add a mechanism for partial updates to ormx similar to what the AsChangeset derive from diesel does.

There are however various possible solutions, the most straightforward one being to require all fields in Patch structs to be wrapped in an Option:

I started discussing this on the discord and @NyxCode kindly responded with interesting alternative ideas that I think are very much worth exploring. I'm quoting their message here to help start the discussion:

yeah so I did think about this a bit in the past. I found that in most cases, it's most comfortable to avoid having to deal with nested Options and stuff like you would have to with diesel. That's also what I needed the most at the time. I do think supporting this would be great though! Would having an attribute like #[ormx(ignore_if_none)] (that name is mediocre, im sure we can come up with something better) work when deriving Patch? I guess we would need something a bit more sophisticated when we still want to be able to derive Patch for the same struct which represents the Table Regardless, I'd definetely appraciate if you would open an issue for this, possibly outlining possible approaches like this