search

NyxTheShield / MIDI2FNF

Convert midi files into Friday Night Funkin' songcharts
30 stars 14 forks source link

No rhyme or reason to how notes are converted #19

Open Thesnakerox opened 3 years ago

Thesnakerox commented 3 years ago

I just tried converting a chart that I wrote as a MIDI into an FNF chart, and it's a very convenient option because FNF's built-in chart editor is very poorly designed. The only problem is, I wrote the MIDI specifically to coincide with the FNF arrows, but there seems to be no rhyme or reason to how notes are converted at all.

According to the tutorial on this script, C, C#, D, and D# coincide with left, down, up, and right, respectively. However, in practice this is not actually the case. Very often two different notes are charted as the same arrow, or two of the same notes are charted as different arrows.

More than that, every single note is on Boyfriend's side, even though I separated the notes into different octaves like the tutorial said to do.

NyxTheShield commented 3 years ago

Look carefully where those notes are placed. It's not a random C, C#, D# or D, they have to be on specific scales.

Thesnakerox commented 3 years ago

I've tried three different octaves ranging from C4 to C7, and none of them have worked.

On Tue, Aug 24, 2021 at 2:45 PM NyxTheShield @.***> wrote:

Look carefully where those notes are placed. It's not a random C, C#, D# or D, they have to be on specific scales.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NyxTheShield/MIDI2FNF/issues/19#issuecomment-904997900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2RGDY2WQKVD4MWDFLLZC3T6QHGHANCNFSM5CXWDKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

NyxTheShield commented 3 years ago

You are doing something wrong, Maybe you are on a different midi channel or some other issue. Code is clear and objective, as long as your midi notes start in the middle C aka midi note 60, it will work.

Thesnakerox commented 3 years ago

Okay, I got it working for Boyfriend's side; MIDI note 60 is his left arrow. Which MIDI note is the opponent's left?

On Tue, Aug 24, 2021 at 2:49 PM NyxTheShield @.***> wrote:

You are doing something wrong, Maybe you are on a different midi channel or some other issue. Code is clear and objective, as long as your midi notes start in the middle C aka midi note 60, it will work.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NyxTheShield/MIDI2FNF/issues/19#issuecomment-905000036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2RGD5OQVWHIZXLY3NPTB3T6QHXLANCNFSM5CXWDKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

NyxTheShield commented 3 years ago

One octave up, so 72 and up

Thesnakerox commented 3 years ago

Got it, thanks!

On Tue, Aug 24, 2021 at 3:19 PM NyxTheShield @.***> wrote:

One octave up, so 72 and up

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NyxTheShield/MIDI2FNF/issues/19#issuecomment-905014888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2RGD3PN653O5XWI6WKXJLT6QLGLANCNFSM5CXWDKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

Thesnakerox commented 3 years ago

Also it would probably be helpful to specify those numbers on the GitHub page's instructions so no one else will end up thinking it doesn't work like I did!

On Tue, Aug 24, 2021 at 3:19 PM Thesnakerox @.***> wrote:

Got it, thanks!

On Tue, Aug 24, 2021 at 3:19 PM NyxTheShield @.***> wrote:

One octave up, so 72 and up

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NyxTheShield/MIDI2FNF/issues/19#issuecomment-905014888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2RGD3PN653O5XWI6WKXJLT6QLGLANCNFSM5CXWDKDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .