Mart-Bogdan
commented
1 year ago I was able to create patch by myself. But it requires for me to create second mod, that is loaded after yours.
Would be nice if you could just take my code and include it into your code.
using System;
using System.Diagnostics;
using HarmonyLib;
using UnityEngine;
namespace ModManagerLinuxFix.Patches
{
internal class ModManagerPatch
{
public static void InstallPatch(Harmony harmony)
{
var ourType = typeof(ModManagerPatch);
var updaterType =
typeof(Ony.OxygenNotIncluded.ModManager.Settings).Assembly.GetType(
"Ony.OxygenNotIncluded.ModManager.Updater");
var method_OpenModFolder = updaterType.GetMethod("OpenModFolder");
var method_OpenLogFolder = updaterType.GetMethod("OpenLogFolder");
harmony.Patch(
method_OpenModFolder,
prefix: new HarmonyMethod(ourType.GetMethod(nameof(ModManagerPatch.OpenModFolder)))
);
harmony.Patch(
method_OpenLogFolder,
prefix: new HarmonyMethod(ourType.GetMethod(nameof(ModManagerPatch.OpenLogFolder)))
);
}
public static bool OpenModFolder(KMod.Mod mod)
{
string root = mod.file_source.GetRoot();
if (Application.platform == RuntimePlatform.WindowsPlayer)
Process.Start("explorer.exe", root.Replace("/", "\\"));
else
Process.Start("xdg-open", '"' + root.Replace("\"", "\\\"") + '"');
// Skip original method
return false;
}
public static bool OpenLogFolder(ModsScreen modsScreen)
{
if (Application.platform == RuntimePlatform.WindowsPlayer)
Process.Start("explorer.exe",
Environment.ExpandEnvironmentVariables(
"%USERPROFILE%\\AppData\\LocalLow\\Klei\\Oxygen Not Included"));
else if (Application.platform == RuntimePlatform.OSXPlayer)
// perhaps use for mac `open` instead of file. But I can't test it.
// And I don't know if MacOS would expand ~, coz Linux doesn't
Process.Start("file://", "~/Library/Logs/Unity");
else
// ~ isn't expanded by OS. $HOME can be expanded if used with `sh -c` but it become tricky with escaping
// quotes, so better to expand env variable at C# side, using dotnet(windows) syntax with % instead of $
Process.Start("xdg-open",
'"' + Environment.ExpandEnvironmentVariables("%HOME%/.config/unity3d/Klei/Oxygen Not Included") +
'"');
// Skip original method
return false;
}
}
}Thanks
O-n-y
As I can see orgiginal way of calling don't work, but it returns 0 exit code for some wierd reason. I think it wasn't ablt to create file.
If I click [Open folder] or [Open Log Folder] nothing happens.
When I go to logs I can observe following message:
From my understanding mod is correctly using
xdg-opencommand, which I originally wanted to suggest as a fix. But it fails to process spaces in path. Full path to game profile dir on Linux is:/home/winnie/.config/unity3d/Klei/Oxygen Not Included/For example when I run in terminal:
And second one works.
Perhaps you just should wrap path into quotes, or screen spaces as
\.But what bugs me, that in case of Ony it complains about first path segmend, not on word
Notas in my case. Perhaps command line generated by Mod is bigger.I would be happy to assist in testing on Linux if you provide me with built DLL.
P.S. I can't add labels, seems only repository owner can do this :-(
Thanks.