search

O-n-y / oxy.mods

Oxy.BugTracker
13 stars 2 forks source link

[DGSM] Bug: Editting multiple duplicant properties cause crash #137

Closed StrikerCodes closed 4 months ago

StrikerCodes commented 8 months ago

Description

After worldgen, at initial duplicant selection, editing multiple duplicants causes the game to crash.

Expected behavior

Opening the edit properties screen of multiple duplicants and editing them makes changes to the duplicants, and pressing the apply changes button applies the change to the duplicants to be spawned.

Actual behavior

Opening the edit properties screen on multiple duplicants causes the apply changes button becomes unresponsive on the older duplicant, and pressing any other buttons in the screen leads to game crash.

Steps to reproduce

  1. Start a normal game
  2. continue until starting duplicants screen
  3. click edit duplicant on 1st and 2nd duplicant
  4. click apply changes to 2nd duplicant
  5. apply changes on first duplicant becomes unresponsive (bug)
  6. clicking any other buttons leads to game crash (bug)

step_1 step_2 step_3 step_4 step_5

DMFan79 commented 7 months ago

I'm having the exact same problem. This is what the game shows after the crash:

NullReferenceException

Ony.OxygenNotIncluded.Tools.ShowDialogMenu (System.String name, System.String title, UnityEngine.GameObject owner, System.Action`2[T1,T2] addButtons, System.Int32 height, Ony.Unity.UI.ScrollPosition scrollPosition) (at <f7900d98c6fe46e5b62b12c9e2b3c9bb>:0)
Ony.OxygenNotIncluded.DGSM2.CharacterHelper+<>c__DisplayClass10_2.<GenerateTraitsView>b__0 (KKeyCode code) (at <f7900d98c6fe46e5b62b12c9e2b3c9bb>:0)
KButton.SignalClick (KKeyCode btn) (at <1e2b7d5db95c4d6b84eabb7ca0270927>:0)
KButton.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) (at <1e2b7d5db95c4d6b84eabb7ca0270927>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) (at <e9635660f69b4d9d84c085aeda3be353>:0)
UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction`1[T1] functor) (at <e9635660f69b4d9d84c085aeda3be353>:0)
UnityEngine.EventSystems.EventSystem:Update()

Build: U50-583750-S
taozhiyu commented 6 months ago

crash Video here:

(ignore other mods, I‘m sure not caused by them)

https://github.com/O-n-y/oxy.mods/assets/49258735/511406b1-a9cd-4921-b416-ba276438b768

Murkyflurky commented 5 months ago

Can confirm this happens to me with specifically only Ony mods (No drop and the mod manager besides DGSM), and mod version showed as: 3.6.2.16 And game build shows as: 587362-5

O-n-y commented 5 months ago

Will be fixed on upcoming release version 3.6.7.37+ (currently in BETA via patrons)

O-n-y commented 4 months ago

fixed