[Skills Master]1.0.1.25 Crash on selecting MinionStorage duplicants

[Sgt-Imalas]

Selecting a Duplicant that is inside a MinionStorage will crash the game

MinionStorages are used with storing duplicants in BaseGame-Rockets (control module and sightseeing module), Spaced Out Trailblazer modules (while landing) and a few mods

Duplicants stored this way have a StoredMinionIdentity component instead of a MinionIdentity component

easiest way to replicate the crash:

• build a base game rocket control or sightseeing module
• assign duplicant
• wait for duplicant to enter rocket
• select duplicant on skills screen

[O-n-y]

Please do provide more information, following How to Report Bugs section https://github.com/O-n-y/oxy.mods

[Sgt-Imalas]

`[13:11:59.535] [1] [INFO] Skills Master // by @Ony 's patched_method SkillsScreen.OnShow matched in the stack trace, adding to referenced mods list NullReferenceException: Object reference not set to an instance of an object at Ony.OxygenNotIncluded.SkillsMaster.Patches.Stats.Set (SkillsScreen skillsScreen, UnityEngine.GameObject go) [0x000b3] in :0 at Ony.OxygenNotIncluded.SkillsMaster.Patches.SkillsScreen_OnShow.Postfix (SkillsScreen instance, System.Collections.Generic.Dictionary2[TKey,TValue] _worldDividers, System.Boolean show) [0x000da] in :0 at (wrapper dynamic-method) SkillsScreen.SkillsScreen.OnShow_Patch1(SkillsScreen,bool) at KModalScreen.OnActivate () [0x00000] in <3d436e4ec1d5455793674ec559b0cc77>:0 at SkillsScreen.OnActivate () [0x00007] in <3d436e4ec1d5455793674ec559b0cc77>:0 at KScreen.Activate () [0x00017] in <3ca21dc18eae422d87255277091f8593>:0 at ManagementMenu.ToggleScreen (ManagementMenu+ScreenData screenData) [0x00172] in <3d436e4ec1d5455793674ec559b0cc77>:0 at ManagementMenu.OnButtonClick (KIconToggleMenu+ToggleInfo toggle_info) [0x00012] in <3d436e4ec1d5455793674ec559b0cc77>:0 at KIconToggleMenu.OnClick (System.Int32 i) [0x00022] in <3d436e4ec1d5455793674ec559b0cc77>:0 at KIconToggleMenu+<>cDisplayClass18_0.b0 () [0x00000] in <3d436e4ec1d5455793674ec559b0cc77>:0 at Util.Signal (System.Action action) [0x00003] in <3ca21dc18eae422d87255277091f8593>:0 at KToggle.Click () [0x000a4] in <3ca21dc18eae422d87255277091f8593>:0 at KToggle.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) [0x0002c] in <3ca21dc18eae422d87255277091f8593>:0 at UnityEngine.EventSystems.ExecuteEvents.Execute (UnityEngine.EventSystems.IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) [0x00007] in :0 at UnityEngine.EventSystems.ExecuteEvents.Execute[T] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.ExecuteEvents+EventFunction1[T1] functor) [0x0006c] in

:0 UnityEngine.DebugLogHandler:Internal_LogException(Exception, Object) UnityEngine.DebugLogHandler:LogException(Exception, Object) UnityEngine.Logger:LogException(Exception, Object) UnityEngine.Debug:LogException(Exception) UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction1) UnityEngine.EventSystems.StandaloneInputModule:ReleaseMouse(PointerEventData, GameObject) UnityEngine.EventSystems.StandaloneInputModule:ProcessMousePress(MouseButtonEventData) UnityEngine.EventSystems.StandaloneInputModule:ProcessMouseEvent(Int32) UnityEngine.EventSystems.StandaloneInputModule:ProcessMouseEvent() UnityEngine.EventSystems.StandaloneInputModule:Process() UnityEngine.EventSystems.EventSystem:Update()` Release.Mod.SkillsMaster Version: 1.0.1.25 Reason for the crash: When looking at a duplicant in a MinionStorage, SkillsScreen.GetMinionIdentity returns null for minionIdentity and a reference to the stored duplicant as a StoredMinionIdentity), thats not handled here

[O-n-y]

can you please provide the save file, so i can test it out? Thanks!

[Sgt-Imalas]

Clicking on the Duplicant "Ellie" in the skill screen will crash the game (since the duplicant is inside the sightseeing module):

SkillsMasterCrash.zip

[O-n-y]

Thank you! Will check it out

[O-n-y]

Can you please confirm the save file in game named as "SkillsMasterCrash" (maybe you renamed file itself and it had some other name)?

[O-n-y]

ok, i think i located it - "Grimy Base" it is :)

[O-n-y]

Will be fixed in upcoming release build, thank you for the reporting

[O-n-y]

[O-n-y]

1.0.2.6 release version is live on Steam