search

O-n-y / oxy.mods

Oxy.BugTracker
17 stars 2 forks source link

CTD Conflict with Notification Suppressions #62

Closed HostileGForce closed 2 years ago

HostileGForce commented 2 years ago

Hello! I am currently getting a conflict causing a crash to desktop when the Research Manager is enabled along with Suppress Notifications by AZE is also enabled. Not sure what the conflict is but here is a recent crash report. With only Research Manager disabled, it works so I do not think Research queue is causing an issue.

Error in ResearchScreen.ResearchScreen.OnSpawn System.NullReferenceException: Object reference not set to an instance of an object at SuppressNotifications.Patch_NotificationScreen_RemoveNotification.Prefix (Notification notification) [0x00000] in :0 at (wrapper dynamic-method) Notifier.Notifier.Remove_Patch1(Notifier,Notification) at Ony.OxygenNotIncluded.ResearchManager.ResearchManager.Notify () [0x000d7] in :0 at Ony.OxygenNotIncluded.ResearchManager.ResearchManager.UpdateResearchState () [0x00079] in :0 at Ony.OxygenNotIncluded.ResearchManager.ResearchManager.ClearQueue () [0x00094] in :0 at Ony.OxygenNotIncluded.ResearchManager.ResearchManager.LoadPreset (System.Collections.Generic.List`1[T] importedData) [0x00000] in :0 at Ony.OxygenNotIncluded.ResearchManager.ResearchManager.LoadPreset () [0x00000] in :0 at Ony.OxygenNotIncluded.ResearchManager.ResearchScreen_OnSpawn.Postfix (ResearchScreen __instance, System.Boolean show) [0x000f6] in :0 at (wrapper dynamic-method) ResearchScreen.ResearchScreen.OnShow_Patch1(ResearchScreen,bool) at KModalScreen.OnActivate () [0x00000] in :0 at KScreen.Activate () [0x00017] in :0 at KScreen.OnSpawn () [0x0004e] in :0 at (wrapper dynamic-method) ResearchScreen.ResearchScreen.OnSpawn_Patch1(ResearchScreen) at KMonoBehaviour.Spawn () [0x0005d] in :0

at UnityEngine.Debug.LogError (System.Object message, UnityEngine.Object context) [0x00000] in <9fe2cbebfa394c8da6af069ec8cc9ef4>:0 at Debug.LogError (System.Object obj, UnityEngine.Object context) [0x00000] in :0 at DebugUtil.LogErrorArgs (UnityEngine.Object context, System.Object[] objs) [0x00000] in :0 at DebugUtil.LogException (UnityEngine.Object context, System.String errorMessage, System.Exception e) [0x00000] in :0 at KMonoBehaviour.Spawn () [0x00000] in :0 at KMonoBehaviour.Start () [0x00000] in :0 Build: U38-486708-S

O-n-y commented 2 years ago

First of all, please read How to report bugs: https://github.com/O-n-y/oxy.mods You should provide the mod version you are using, when posting an issue.

Secondary, if the version if the last - there is no guarantee all mods are compatible with each other. If mods change the same part of the code of the base game (and especially if the mod use code trampoline), this could provide incompatibility with other mods.

O-n-y commented 2 years ago

In this particular case only, could mean the mod creator used Notifier system not fully correctly and left notifier field null, which should not be null. I will add a null check in the next build of Research Manager, but the creator of the mod you are talking about should fix this issue as well.

O-n-y commented 2 years ago

Updated version 1.1.8.175

O-n-y commented 2 years ago

thank you for the report, the update is live! :)

HostileGForce commented 2 years ago

Thank you for the update. Sorry about not following the correct reporting as you asked. I was not around yesterday and did not expect such a quick turn around! Aze was also looking into it and found some other conflicts in my mod list and contacted those authors for me so hopefully everything works smoothly. I really appreciate all the hard work you put into making these amazing mods and maintaining them!