search

O-n-y / oxy.mods

Oxy.BugTracker
19 stars 2 forks source link

[Mod Manager] Crash on attempting to update mods, caused by missing sanity check #81

Closed Vectrobe closed 1 year ago

Vectrobe commented 2 years ago

A not-null and not-empty check on the URL string is necessary, else the update-mods-on-startup feature just crashes the game if any mods exist that dont have an obtainable URL.

ArgumentNullException: Value cannot be null. Parameter name: requestUriString

System.Net.WebRequest.Create (System.String requestUriString) (at :0) Ony.OxygenNotIncluded.ModManager.FileDetailsDownloader.Download (System.String url, System.String filePath) (at :0) Ony.OxygenNotIncluded.ModManager.Updater+d__16.MoveNext () (at :0) UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <9fe2cbebfa394c8da6af069ec8cc9ef4>:0)

Build: U41-498381-S

O-n-y commented 2 years ago

Provide the mod name or url which cause this issue (had null url) as this should never happen

O-n-y commented 1 year ago

should be resolved at current release version of the mod 2.13.7.125