O365 / python-o365

A simple python library to interact with Microsoft Graph and Office 365 API
Apache License 2.0
1.6k stars 411 forks source link

Update calendar.py::EventRecurrence::__repr__() #1037

Closed Invincibear closed 5 months ago

Invincibear commented 6 months ago

Handle plural units of measurements

Invincibear commented 6 months ago

turns something like "Daily: every 3 day/s" into "Daily: every 3 days" and "Weekly: every 1 week/s" into "Weekly: every 1 week"

Invincibear commented 6 months ago

I should've done this in two PRs, I reduced the indentation by one in an additional edit. Lemme know if you want me to split it to make it easier to review, but there's no real change to the logic.

edit: actually if you just look at the two commits you'll see what I did: https://github.com/O365/python-o365/pull/1037/commits

alejcas commented 5 months ago

merged, thanks