search

O365 / python-o365

A simple python library to interact with Microsoft Graph and Office 365 API
Apache License 2.0
1.65k stars 419 forks source link

Add custom headers to email #1079

Closed ted-mey closed 3 months ago

ted-mey commented 4 months ago

This a continuation on an existing PR #871 , and tries to handle the comments there. Also adding the property before the restrict_keys part to not sidestep that functionality.

We want to be able to send custom headers to the email, as supported in this example i MS docs.

I added two unit tests to verify the behavior ~but I wasn't able to test it with the live environment~. I've tested it with my O365-account and I think it works as expected.

ted-mey commented 3 months ago

@alejcas what do you think?

alejcas commented 3 months ago

@alejcas what do you think?

Well I commented your code but you didn’t answer

ted-mey commented 3 months ago

@alejcas what do you think?

Well I commented your code but you didn’t answer

I'm sorry, I can't find any other comments except for this one. Where can I find them?

If you refer to the comments you made on the older PR that I've linked to, it wasn't made by me and I've tried to implement those suggestions.

alejcas commented 3 months ago

image

ted-mey commented 3 months ago

@alejcas what do you think?

image

Thank you! I've updated the code with your suggestion to fix the issue.

The reason why I can't see your comment is because it's "Pending", you need to submit it for me to be able to see it. Here is a github issue with lots of people confused about the UX.

alejcas commented 3 months ago

@alejcas what do you think?

image

Thank you! I've updated the code with your suggestion to fix the issue.

The reason why I can't see your comment is because it's "Pending", you need to submit it for me to be able to see it. Here is a github issue with lots of people confused about the UX.

Embarrasing...

Review submited

Please see the comments

alejcas commented 3 months ago

Thanks!

ted-mey commented 3 months ago

Thanks!

Thank you! What is the schedule of releases of this package? I noticed the last version is from februari on pypi. We would love to be able to use this in our application, when do you think it will be available?

alejcas commented 3 months ago

I usually wait until there are a coupe/more improvements on master.

Let me check and I’ll report back

alejcas commented 3 months ago

2.0.35 released