O365 / python-o365

A simple python library to interact with Microsoft Graph and Office 365 API
Apache License 2.0
1.68k stars 423 forks source link

Bug: Unable to retrieve or add homeAddress from Contacts(address_book.py) #989

Closed wbg0 closed 1 year ago

wbg0 commented 1 year ago

Hi,

In the current state it is not possible to retrieve or add homeAddress, because of a simple typo.

address_book.py line 94: self.home_address = cloud_data.get(cc('homesAddress'), {}) should be: self.home_address = cloud_data.get(cc('homeAddress'), {})

as well as on line 372: self._track_changes.add(self._cc('homesAddress')) should be: self._track_changes.add(self._cc('homeAddress'))

and the last one on line 473: cc('homesAddress'): self.__home_address, should be: cc('homeAddress'): self.__home_address,

kwilsonmg commented 1 year ago

I am surprised that this wasn't a pull request by someone. Until this gets merged you can use my fork @wbg0 . I've fixed the issue there as you described.

alejcas commented 1 year ago

Fixed in #1013