O3Labs / OzoneWalletIOS

The main repo for the O3 wallet on iOS
MIT License
9 stars 11 forks source link

Native Trade view title #93

Open AGKDesigns opened 6 years ago

AGKDesigns commented 6 years ago

At the moment if you want to sell GAS and then swap the token to something else it still says Sell GAS.

We will need to change the heading of the native trade view away from buy and sell "OOO" I think, if we allow users to sway, it will need to swap the heading every time which is not good practice generally without changing screens.

Perhaps it could be something more generic like "Trade"

apisit commented 6 years ago

are you on the latest version?

AGKDesigns commented 6 years ago

Ah it seems fixed now, I still get sort of confused by it, being able to change the pairs. Maybe thats just me though. I feel like the icons and the headers are disconnected some how.

apisit commented 6 years ago

oh I see now. it says sell GAS but doesn't say "to"

apisit commented 6 years ago

how about we say " Trade [LEFT SIDE] for [RIGHT SIDE]" ? e.g. sell SWTH for NEO would be "Trade SWTH for NEO" buy SWTH with NEO would be "Trade NEO for SWTH"

AGKDesigns commented 6 years ago

yeah that makes more sense to me.