search

OAGi / Score

Score
MIT License
9 stars 6 forks source link

Allow non-BIE owners view-only access to BIEs in WIP status #1312

Open jim-wilson-kt opened 2 years ago

hakjuoh commented 2 years ago

@kbserm A concern we had was that the viewer may either encounter system errors or see stale data when the owner changes the BIE. Perhaps the best way to solve those issues is to introduce more sophisticate user access controls and multiple ownerships of the BIE, so that the multiple users simultaneously update properties. We will investigate this in the future milestone. For now, I applied the server-sent event techniques in order to prevent those issues. BIE viewers will see the following messages when the owner of BIE changes any properties

Screen Shot 2022-08-11 at 5 47 48 PM

, or the BIE state is changed

Screen Shot 2022-08-11 at 5 48 30 PM

, or the ownership of the BIE is transferred

Screen Shot 2022-08-11 at 5 49 40 PM

, or the BIE is discarded.

Screen Shot 2022-08-11 at 5 52 02 PM

One drawback from this is that the viewer may keeps seeing notification messages if the owner frequently changes properties while the viewer is observing.

Note that the reason I took the Notiflix report box we've seen in above is that the message box in Angular Material Snackbar is too small to print a long message.

dubnemo commented 2 years ago

@hakjuoh the proposal leads to collaborative BIE editing. We had talked about that long ago, but if you think this is feasible through these notifications, I completely agree we get this into 2.4.

kbserm commented 2 years ago

@hakjuoh In the dialog boxes above. 1) In the ownership transfer case, why it says so specifically that the ownership is transferred to you. What about when it is transferred to somebody else, so why not just say "The ownership has been transferred." 2) In the case of Discard, what is the "previous page", which page will load if the Back button is clicked?

@jim-wilson-kt Please let us know if you need these notifications that @hakjuoh suggested? Or can we simply document in the User Guide that viewing a WIP or QA BIE can mean you are looking at a stale content. @hakjuoh So as you can see, even a QA BIE can stale, not just a WIP. So since the beginning, the BIE state is more about conveying the maturity of the BIE and not so much about preventing someone from seeing stale content.