search

OAGi / Score

Score
MIT License
9 stars 6 forks source link

Score to track github issues for component changes #1533

Open joshklm opened 1 year ago

joshklm commented 1 year ago

When user moves a component change to Candidate state, Score tool should popup an input dialog for user to add the Github issue(s) and comments. The entry will be saved for future review/assessment, and also for a notification when the user tries to revert the component back from the Candidate state. This will solve the problem of potentially losing changes to a component tied to multiple Github issues.

joshklm commented 1 year ago

This issue is generated during the 8/11 OAGi Architecture Meeting with @joshklm @michaelfigura @jim-wilson-kt @sfohn regarding lost changes related to several Github issues that were previously approved for OAGIS 10.9.x releases.

kbserm commented 1 year ago

@joshklm could you provide more detail about the notification.

dubnemo commented 1 year ago

My four-cents** worth:

When a Developer clicks the Cancel button, there should be a list box dialog pop-up showing the components ('what") that have been previously added or changed since clicking on the Revise button, as well as the date-time of that addition or changed ("when"). The list can be sorted newest to oldest, so the Developer can highlight the most recent changes that can be 'deleted' in a compensatory manner without affected the changes that need to be preserved.

I recommend a Copy to Clipboard button so the Developer can paste that list in Notepad++ and manage these fixes off line.

There can be Next >> button to Confirm 100% that the Developer wants to Cancel ALL the changed present in the Dialog box.

** inflation has increased the value of my opinion.

joshklm commented 1 year ago

@kbserm Yes. @dubnemo just nailed it with his inflation adjusted opinion. :) I'm not sure if it's called Cancel button. I think it's called 'Revert' to get to WIP State from Candidate state. During the meeting on 8/11 we found out that the person who is reverting the component from Candidate state back to WIP may not realize (or simply forgot) that the component had updates to cover multiple github issues for the delivery under the target OAGIS release.