OAGi / Score

Score
MIT License
9 stars 6 forks source link

Error when updating BIE with new code lists #1546

Closed jim-wilson-kt closed 1 year ago

jim-wilson-kt commented 1 year ago

connectCenter instance: https://demo.oagiscore.net User: oagis Branch: HR Open 5.1 BIE: Person Video: https://app.screencast.com/93GTO02z0cJ1i

I have created a Person BIE using components I created in the HR Open Standards namespace. I have also created code lists, which three of the components use. When I check any of them for the BIE and then click the "Update" button, I immediately get non-user-friendly errors (see video link above). However, when I click on the link for the component first, I get user-friendly messages when I click on the "Update" button.

image
hakjuoh commented 1 year ago

@jim-wilson-kt If a base data type has a default value that is a code list or agency ID list, the empty BBIE/BBIE_SC should show the default value on the value domain restriction in the BIE page.

Currently, Gender_ Code. Type has Gender Code List as a default value domain as below.

Screenshot 2023-10-05 at 8 55 51 AM

In this case, it should shows Gender Code List on the value domain restriction when the user opens the BBIE whose base data type is Gender_ Code. Type, but currently it shows empty primitives.

Screenshot 2023-10-05 at 8 54 49 AM

I fixed this behavior and uploaded the PR for this. Now it shows correctly.

Screenshot 2023-10-05 at 9 34 43 AM

@bingqi2045 Please review the PR and test it.

kbserm commented 1 year ago

@jim-wilson-kt just a little tip, you don't have to click Update on every node on which you made changes before you leave and move to another node. Might help you reduce the # of clicks!