OAGi / Score

Score
MIT License
9 stars 6 forks source link

OpenAPI document, suppressing root property no longer working #1590

Closed dubnemo closed 8 months ago

dubnemo commented 11 months ago

Reviewing the POST operation:

image

The shippedItemInstance {} root property is present:

image

dubnemo commented 11 months ago

Current OpenAPI document as of 2023-12-27 image

yaml attached as a zip file: In-Field Product Id-V4-1703693859142.zip All verbs have the root property for some reason.

Note: Don't be concerned about the path parameter errors. That is related to final work on OpenAPI document with another page for adding/editing parameters (query, path, headers), http response codes, and more descriptions

dubnemo commented 10 months ago

@hakjuoh can you add in the link to which Java file(s) Bingqi created for the OpenAPI document expression? I think you pasted into Wednesday's G2M call chat window, but that goes away after the session.

hakjuoh commented 10 months ago

@hakjuoh can you add in the link to which Java file(s) Bingqi created for the OpenAPI document expression? I think you pasted into Wednesday's G2M call chat window, but that goes away after the session.

@dubnemo Here's a link: https://github.com/OAGi/Score/blob/master/score-http/score-http/src/main/java/org/oagi/score/gateway/http/api/oas_management/service/generate_openapi_expression/OpenAPIGenerateExpression.java

hakjuoh commented 10 months ago

@elena-jelisic BieOpenAPIGenerateExpression has been used for generating OpenAPI expressions. Bingqi copied it to implement OpenAPIGenerateExpression and made some changes to it. You may need to check both to investigate this issue.

dubnemo commented 10 months ago

@elena-jelisic I just tested in test.oagiscore.net, and I still see the same issues:

image I am available today 2pm Central.

@hakjuoh

dubnemo commented 10 months ago

@elena-jelisic I have checked test.oagiscore.net, and it is working now.