Modified the `add_enums` to avoid collisions

OALabs / hashdb-ida

HashDB API hash lookup plugin for IDA Pro

BSD 3-Clause "New" or "Revised" License

296 stars 39 forks source link

Modified the `add_enums` to avoid collisions #27

Closed anthonyprintup closed 2 years ago

anthonyprintup commented 3 years ago

add_enums now takes one additional argument which has the default value of hdb,
if the suffix isn't empty it's appended to the member_name.

fixes #23

herrcore commented 2 years ago

Looks like (1) is handled nicely here but not (2) (ref https://github.com/OALabs/hashdb-ida/pull/27#pullrequestreview-799133087)

I think it would be best to pass in an is_api flag to add_enums which could be used to decide when to use a suffix and when not to? Open to other suggestions though.

anthonyprintup commented 2 years ago

I think that deciding if a suffix should be used based on if the hash is an API is unnecessary because we have to check if a name is taken either way. Each hash value in the hash list would have to be accompanied by is_api to avoid any shenanigans.