search

OASIS-learn-study / minecraft-storeys-maker

Minecraft extension to make your own stories in, with and for Minecraft - it's like being a movie director!
https://www.learn.study
GNU Affero General Public License v3.0
15 stars 10 forks source link

story parser is buggy, inline JS is not properly parsed #301

Closed vorburger closed 2 years ago

vorburger commented 2 years ago

@edewit does dynamic-test.story, introduced in #173 work?

Can we add that to test.story to illustrate it?

295 and this are somewhat related.

vorburger commented 2 years ago

I've tested it, and the dynamic-test.story example works great.

But if you inline intended blocks in a longer story it doesn't quite work, because the .story parser is really bad; this is a similar problem to #281; I'll probably fix this together, some time.

vorburger commented 2 years ago

This is easily reproducible by adding e.g. "Hello." at the start and "La Fin." at the end of dynamic-test.story - that will break parseDynamic() of StoryParserTest.