search

OASIS-learn-study / minecraft-storeys-maker

Minecraft extension to make your own stories in, with and for Minecraft - it's like being a movie director!
https://www.learn.study
GNU Affero General Public License v3.0
14 stars 10 forks source link

Introduce Checkstyle #346

Closed vorburger closed 2 years ago

vorburger commented 2 years ago

This is a start for #334. The new checkstyle.xml is based on MariaDB4j's, with some minor modifications to match this project.

What's currently still missing here is:

  1. License header (lost in #344)
  2. Annotation in same line
  3. Diff with OpenDaylight's and Apache Fineract's

@edewit do you want to have a look at this and merge this as-is already? I'll work on 1/2/3 above some other time. (Please DO NOT Squash - in this particular case, I think there is value to keep my intentionally well separated 5 commits separately pre-served as-is.)

edewit commented 2 years ago

I can use this eclipse formatter xml also in IntelliJ

vorburger commented 2 years ago

I can use this eclipse formatter xml also in IntelliJ

Oh! Really? That's both surprising to me and pretty cool, that IntelliJ digs Eclipse's format. Perhaps you can add a line to https://github.com/OASIS-learn-study/minecraft-storeys-maker/blob/develop/docs/develop.md explaining to our millions of future IntelliJ using contributors ;-) how to use it?