initial version of the mineflayer based npm test

[edewit]

$> cd test-utils/mineflayer
$> gradle test

This test will fail atm because the server isn't in offline mode and the Player that mineflayer uses doesn't have rights to execute /make

Once these 2 things are fixed this test will pass

[vorburger]

This test will fail atm because the server isn't in offline mode

We COULD change ENV SKIP_SERVER_PROPERTIES from true to false in both Dockerfile and Dockerfile-local AND ENV ONLINE_MODE=FALSE BUT then we'll loose being in creative, because of https://github.com/itzg/docker-minecraft-server/issues/1452. I can't quite think of a "workaround". Unless @edewit you can think of something, i think we have 2 obvious choice here: (a) switch it in our server.properties #L43 (in minecraft-server/ NOT in minecraft-server-test-data), (b) wait for @itzg to release a new image. For me we can do (a) for now, and "later" revert and (b). Unless @itzg jump on this with this incredible support and wants to make a new release in the next few days?

and the Player that mineflayer uses doesn't have rights to execute /make

I'm torn how to best go about this. It seems like a shame to give up on the permission check for /make. But even if we had #276 for LuckPerms (I could priorititze working on that next), I don't know how we would "grant the anonymous Mineflyer user the permission to /make. Hm.

[itzg]

I had gotten myself confused and thought I was caught up on releases 😃 There is now a new release with the changes: https://github.com/itzg/docker-minecraft-server/releases/tag/2022.6.0

[edewit]

Wauw @itzg has our back, so we can do (b)