Closed edewit closed 2 years ago
@edewit just to be explicit and avoid confusion, you don't want me to review (and merge) this one, yet - or do you?
The build currently seems to fail, you're probably still working on this:
> storeys-blockly@0.0.0 build
> tsc && vite build
src/App.tsx(8,21): error TS2307: Cannot find module './app.module.css' or its corresponding type declarations.
src/blockly/Block.tsx(8,5): error TS2339: Property 'block' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(10,5): error TS2339: Property 'block' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(17,5): error TS2339: Property 'category' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(19,5): error TS2339: Property 'category' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(26,5): error TS2339: Property 'value' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(28,5): error TS2339: Property 'value' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(35,5): error TS2339: Property 'field' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(37,5): error TS2339: Property 'field' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(44,5): error TS2339: Property 'shadow' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/Block.tsx(46,5): error TS2339: Property 'shadow' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/BlocklyComponent.tsx(5,20): error TS7016: Could not find a declaration file for module 'blockly/msg/en'. '/project/blockly/node_modules/blockly/msg/en.js' implicitly has an 'any' type.
If the 'blockly' package actually exposes this module, try adding a new declaration (.d.ts) file containing `declare module 'blockly/msg/en';`
src/blockly/BlocklyComponent.tsx(9,21): error TS2307: Cannot find module './blockly.module.css' or its corresponding type declarations.
src/blockly/BlocklyComponent.tsx(59,7): error TS2339: Property 'xml' does not exist on type 'JSX.IntrinsicElements'.
src/blockly/BlocklyComponent.tsx(66,7): error TS2339: Property 'xml' does not exist on type 'JSX.IntrinsicElements'.
> Task :blockly:npmBuildProd FAILED
I'll mark it as a Draft, so that you can Undraft it and ping me when you want me to review it.
@edewit just to be explicit and avoid confusion, you don't want me to review (and merge) this one, yet - or do you?
The build currently seems to fail, you're probably still working on this:
> storeys-blockly@0.0.0 build > tsc && vite build src/App.tsx(8,21): error TS2307: Cannot find module './app.module.css' or its corresponding type declarations. src/blockly/Block.tsx(8,5): error TS2339: Property 'block' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(10,5): error TS2339: Property 'block' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(17,5): error TS2339: Property 'category' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(19,5): error TS2339: Property 'category' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(26,5): error TS2339: Property 'value' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(28,5): error TS2339: Property 'value' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(35,5): error TS2339: Property 'field' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(37,5): error TS2339: Property 'field' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(44,5): error TS2339: Property 'shadow' does not exist on type 'JSX.IntrinsicElements'. src/blockly/Block.tsx(46,5): error TS2339: Property 'shadow' does not exist on type 'JSX.IntrinsicElements'. src/blockly/BlocklyComponent.tsx(5,20): error TS7016: Could not find a declaration file for module 'blockly/msg/en'. '/project/blockly/node_modules/blockly/msg/en.js' implicitly has an 'any' type. If the 'blockly' package actually exposes this module, try adding a new declaration (.d.ts) file containing `declare module 'blockly/msg/en';` src/blockly/BlocklyComponent.tsx(9,21): error TS2307: Cannot find module './blockly.module.css' or its corresponding type declarations. src/blockly/BlocklyComponent.tsx(59,7): error TS2339: Property 'xml' does not exist on type 'JSX.IntrinsicElements'. src/blockly/BlocklyComponent.tsx(66,7): error TS2339: Property 'xml' does not exist on type 'JSX.IntrinsicElements'. > Task :blockly:npmBuildProd FAILED
I'll mark it as a Draft, so that you can Undraft it and ping me when you want me to review it.
We should be fine to merge this as it's not really used yet. I don't know why you are getting these errors I don't get them locally. I'll try to reproduce them
I'll (locally) test and merge this ASAP now... sorry for the delay.
Still todo Todo: