Run full ./test and just ./make for every PR on GCB

OASIS-learn-study / minecraft-storeys-maker

Minecraft extension to make your own stories in, with and for Minecraft - it's like being a movie director!

https://www.learn.study

GNU Affero General Public License v3.0

14 stars 10 forks source link

Run full ./test and just ./make for every PR on GCB #382

Closed vorburger closed 2 years ago

vorburger commented 2 years ago

This is a follow-up to #381 (re. #374) to see if running a full ./test and just ./make would actually work on GCB?

That would be so cool.

vorburger commented 2 years ago

Actually I suspect this won't quite work just yet... it will most probably need #375 to be finished, first.

But once that's done, then this is definitely worth re-trying!

vorburger commented 2 years ago

This doesn't quite work yet, just because ./test still does ./gradlew test-mineflayer:npmTest, which assumes Java & Node are available outside of a container (whereas the rest of the build now happens entirely containerized). We should change it so that actually launching Mineflayer runs from within our build container as well. Then this will work (and be fully portable, and independant of what you toolchain one has locally installed.) /Cc @edewit FYI.