search

OASIS-learn-study / minecraft-storeys-maker

Minecraft extension to make your own stories in, with and for Minecraft - it's like being a movie director!
https://www.learn.study
GNU Affero General Public License v3.0
14 stars 10 forks source link

Improved the tests to also open the browser and create a `/demo` command execute this. #400

Closed edewit closed 1 year ago

vorburger commented 1 year ago

@edewit did you notice that this failed to build on GCB not (yet?) because of a missing browser package, but simply timed out waiting for the server not test container to even get ready? Could you please kindly rebase this PR - I suspect that #404 will help to get past this (only first?) problem, and am curious to see if it works or what it fails with after that...

edewit commented 1 year ago 
Platform: linux-x64 (Debian - 11)
Cypress Version: 10.2.0
[FAILED] Your system is missing the dependency: Xvfb
[FAILED] 
[FAILED] Install Xvfb and run Cypress again.
vorburger commented 1 year ago

[FAILED] Your system is missing the dependency: Xvfb

@edewit I wonder if this may be as simple as inserting xvfb in Dockerfile-build, like this:

RUN curl -fsSL https://deb.nodesource.com/setup_17.x | bash - && apt install -y xvfb nodejs && node --version

Do you want to just try?

vorburger commented 1 year ago

386 now also occurs in the CI build logs for this. Might that be the reason for the test failure?

397 also still happens, but that's not the "cause" but an "effect" - that's why the build "never finishes" and takes 10', at which point GCB times it out and terminates it.

401 also appears, but that's not causing the test failure either.

edewit commented 1 year ago

386 is not the reason for this error it happens when a user adds only a command for example m.cmd('/say hello'); when the script is only one line it can't be executed because m is not defined it only gets passed into an effect.

vorburger commented 1 year ago

@edewit I forgot where we were with this one... do you want to retry how we can get this to pass the build?

edewit commented 1 year ago

We might need to look at this together... I don't see why this "never ends" happens or why the build fails on GCB

edewit commented 1 year ago

@vorburger I think i finally fixed this, can you have another look?

edewit commented 1 year ago

okay almost I think just one more issue with the sound card:

ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
vorburger commented 1 year ago
edewit commented 1 year ago
  • Seems to still fail? Sorry...

Yes I know it's the sound card, but I sorted all the other issues it now stops nicely and no more strange async errors

vorburger commented 1 year ago

Would it possibly make sense to "split" this, and have a PR for just the async fixes, without the headless browser, and then that later? Just a thought.

edewit commented 1 year ago

@vorburger don't know what you mean by split, this PR is now just adding the browser based tests to the mineflayer

vorburger commented 1 year ago

@edewit as discussed, I'm closing this, in favour of our (cool, new; thanks!) #429.