search

OBF / homepage

Code for the OBF's new homepage
http://open-bio.org
5 stars 10 forks source link

Some blog posts not showing dates on open-bio.org/blog #74

Closed nlharris closed 2 years ago

nlharris commented 2 years ago

possibly related to #73? Screen Shot 2022-03-15 at 10 09 20 PM

Hrittik20 commented 2 years ago

Hi @nlharris, can you tell me where I can find the blog file?

yochannah commented 2 years ago

Hey Hrittik - what do you mean by the blog file? Wordpress is based on a php/mysql setup so posts are all stored in the database.

yochannah commented 2 years ago

actually, you probably mean just which page to edit, right? I think it's this one. https://github.com/OBF/homepage/blob/14e698d2a5f09d762f2599941d21e40f7af0399f/home.php

erik-whiting commented 2 years ago

Hello, I am pretty sure I know how to fix this but have a quick question about setup.

I've Dockerized the app and have the WP instance running locally in a container but I can't get beyond Step 5 in the README.md. When I click the link "Import WP Migration" I just see this:

image

There's no "Basic" version for me to download and then import. I'm assuming this is something like seed data for the blog?

Anyway, I'm 99% sure that calls to the_date() need to be changed to get_the_date("F j, Y") because according to this answer, this is a well known issue with the_date because it won't say the same date more than once (so if two articles are posted on the same day, only the first one will have the date, the second wont'). I made a PR implementing this fix, but I can't know for sure if it works until I get the site running locally (or someone with a local instance tests my branch).

erik-whiting commented 2 years ago

Howdy @nlharris and @yochannah, just wanted to ping y'all again and bring your attention to this possible fix. Let me know if there's anything I can clarify or take care of for you.

nlharris commented 2 years ago

Hey, sorry, I have no idea. Maybe @hzahroh would know?

erik-whiting commented 2 years ago

Hello again @nlharris and @yochannah . Through the magic of Docker and general hackery, I was able to fake my way through enough of the setup to actually test my PR. I can confirm that this pull request fixes the problem in this issue. Let me know if there's anything you'd like me to change!

hlapp commented 2 years ago

Turns out that for some reason this didn't yet fix the issue, see https://github.com/OBF/homepage/pull/78#issuecomment-1191957008

erik-whiting commented 2 years ago

@hlapp this looks like it's working now. Can you double check the news page and confirm you see what I see (working dates)?

nlharris commented 2 years ago

Yes, it seems to be working now! Thanks so much for your help, @erik-whiting!