OBF / homepage

Code for the OBF's new homepage
http://open-bio.org
5 stars 10 forks source link

Improve layout of social icons in footer of BOSC pages #84

Closed nlharris closed 1 month ago

nlharris commented 1 year ago

not pressing, but it would be nice if the icons didn't wrap to a second row.

Screen Shot 2023-02-27 at 2 52 49 PM

Karsten wrote:

In the Theme File Editor I found the following entry, which seems to control the arrangement of icons into five columns:

.networks {
    display: grid;
    grid-template-columns: 15% 15% 15% 15% 15%;
}

I assume there must be a reason for the network logos to sum up to 60%, so I changed it to 

.networks {
    display: grid;
    grid-template-columns: 10% 10% 10% 10% 10% 10%;
}

That worked for the OBF footer:
<image.png>
(unfortunately this only shows in Firefox - Chrome is still displaying the old version, must be cached)

There is a similar section for BOSC footers in the file css/style-bosc.css on GitHub:

.bosc-footer-sub-section .networks {
    display: grid;
    grid-template-columns: 18% 24% 18% 18% 18%;
}

Looks like the Twitter logo needs a bit of extra space due to the hashtag below it.
Not sure if it's important for the grid to sum up to 96%, but if so, this could work:

.bosc-footer-sub-section .networks {
    display: grid;
    grid-template-columns: 15% 21% 15% 15% 15% 15%;
}
SrijanVerma04 commented 1 year ago

Hi @nlharris can I contribute to this issue. That grid-template-columns : 15% 21% 15% 15% 15% 15% looks very accurate. I tried changing the display to inline-flex but that doesn't work as the twitter hashtag will be inline.

Can i create a pull request with changing the grid percentage that will allign all the icons?

peterjc commented 1 month ago

Closed by #88