Make theme compatible with FreeCAD 0.19.x

OBKF / Prof-CAD

Prof-CAD Dark/Light Themes Inspired by Prof-Gnome for FreeCAD

Creative Commons Attribution Share Alike 4.0 International

1 stars 0 forks source link

Make theme compatible with FreeCAD 0.19.x #1

Open luzpaz opened 4 years ago

luzpaz commented 4 years ago

0.18.4 is light years behind 0.19.x
Consider adapting the theme for the latest 0.19.x version.
https://github.com/FreeCAD/FreeCAD/releases/tag/0.19_pre

luzpaz commented 3 years ago

bump

OBKF commented 3 years ago

@luzpaz Hi, sorry my laptop broke and l got distracted for a while.

So I retested with 0.19 and it works as intended, so there are no changes needed as far as I have tested, I will updated the description after your feedback, so please test it.

FreeCAD_dark_theme_0 19

luzpaz commented 3 years ago

Take a look at https://github.com/turn211/ProDark-FreeCAD-theme/
he's made some key issue fixes some of them have been applied to the rest of the upstream themes in FreeCAD master. For example: https://github.com/FreeCAD/FreeCAD/commit/518a9fcbaf3dc8ce0dd75b445e3dd4edfb2f1d32 which solved https://tracker.freecadweb.org/view.php?id=4559

OBKF commented 3 years ago

@luzpaz I only have 1366x768px laptop monitor so I haven't noticed, I will update the theme based on the linked one. Thanks for notifying me.

luzpaz commented 3 years ago

Sweet! thank you for responding