OBOAcademy / obook

OBO Organized Knowledge: Training materials for becoming an OBO engineer
https://oboacademy.github.io/obook/
Creative Commons Zero v1.0 Universal
91 stars 38 forks source link

Some feedback on ontology matching lesson #345

Open matentzn opened 1 year ago

matentzn commented 1 year ago

Some user feedback on the semantic entity matching tutorial:

I'd like to know if any particular execution orders exist among these rules. In this example, the order does not matter, but it may matter if the rulesets become complex.

Good question, @hrshdhgd can you supply the answer?

Are there any guidelines on setting this weight? For example, I wonder if you have any rationales for setting the weight as 2; I wish to know more about its meaning, heuristics, or mechanism; how does it work, and what happens behind it?

We should add a sentence in the tutorial and the oak docs.

I would like to see more examples of these rules; it does not have to be food or recipe examples, btw. I just wish to understand better how to use your rulesets for the alignment of the nodes in graphs. It would be also helpful if you could list down rule examples with problem descriptions or any specific common patterns, e.g., to solve a problem X, we set the rule this way, etc.

Add a list of example rules at the end of the tutorial?

I wish to see more details on "Mapping Rules Datamodel"; I wish that we could have full descriptions of all the classes and slots on that page; hopefully, they can also be linked to the examples mentioned above.

This opens up a nice question: how should linkml data models be summarised to a prospective user?

Can you add hyperlinks on the tutorial in the final sentence?, i.e., "For a more detailed introduction into manual mapping curation with SSSOM we recommend following this tutorial: https://mapping-commons.github.io/sssom/tutorial/."

hrshdhgd commented 1 year ago

I'd like to know if any particular execution orders exist among these rules. In this example, the order does not matter, but it may matter if the rulesets become complex.

The implementation of the rules are top-bottom anyways so the order in the YAML file will be respected.