OBOFoundry / COB

An experimental ontology containing key terms from Open Biological and Biomedical Ontologies (OBO)
https://obofoundry.github.io/COB
Creative Commons Zero v1.0 Universal
35 stars 8 forks source link

NTR: observing system #190

Open cmungall opened 2 years ago

cmungall commented 2 years ago

ENVO has a class observing system http://purl.obolibrary.org/obo/ENVO_01001469 A system of constructed and manufactured products which are used by humans to produce data, information, or knowledge about material, immaterial, or processual entities. cc @pbuttigieg

This has a single child (observatory) and some grandchildren

image

This is a bit problematic - the definition of observing system is broad enough that it should encompass many classes in OBI (@bpeters42), and machines such as MRI machines, yet users may be confused not to see OBI classes under here

The parent term 'system' is not in COB (I am responsible for the class 'system' in RO, which was introduced by Barry in https://jbiomedsem.biomedcentral.com/articles/10.1186/s13326-016-0097-6 -- Barry said this term would make it's way into BFO)

I think there is room for a very general class in COB that can cover a variety of material entities that have a role in sensing for investigative purposes. I would strongly recommend this have a logical definition with a simple pattern, such that different ontologies that have such sensory-investigative systems will have terms auto-classified here.

Alternatively OBI could adopt this entire branch of ENVO (via obsoletion-replacement), but a challenge here is there are users e.g. NASA who want this for Planetary Science, Heliophysics, Biology, Physical Science and Earth Science... (@rduerr)

bpeters42 commented 2 years ago

As said elsewhere, we should create a COB:device class that serves as a broad parent, and 'detection device' or something like that as a child that is defined by its function and should serve all of those purposes. We had talked about this in the OBI calls, and as I recall (but I DONT speak for obi) there were no objections.

I do want to point out that device / instrument / detectors are defining classes of what OBI was created for, and we have decades of work on these terms. So this would not be something done lightly

ddooley commented 2 years ago

So an observing system is a set of material things used by an observing process to output observations? Connected to this, in another draft paper I was proposing that we have:

An observation: An observation is a data item resulting from an invasive or non-invasive observation process occurring at an instant or duration of time, and includes at least one measure that (semantically) “is about” a characteristic of an entity (for example Jane Doe’s weight). Other aspects of an observation may be documented: the particular time and context it happened in, and the sensor (device or human or other organism organ) that was involved.

This is accompanied by an analysis of SOSA entities and relationships and what OBO was missing (e.g. "sensor") in that mix. So this move to add observation system is very opportune. In diagram below, "assay" could be replaced with a more general "observation process"? image

rduerr commented 2 years ago

Replacing assay with a more general "observation process" would be fine by me - though I suspect the GeneLab folks would like to keep the term assay perhaps as a child of "observation process" since their system uses that throughout. Aligning with SOSA is also great as it would simplify my life (OK actually my current project).

ddooley commented 2 years ago

Ok! But to be clear I meant create a new term "observation process" and put it into the diagram. But only if the new term is clearly broader in scope (and therefore parent of) "assay".

DanBerrios commented 2 years ago

@ddooley I agree... Seems correct to add observation process as parent of assay, and as a child of planned process, and also import ENVO observing system and make device or investigative-device a parent of observing system. No?

GeneLab uses "assay", and it should stay I think...not every observing process is going to be called an assay.

bpeters42 commented 2 years ago

I do want to make sure that I don't come across as trying to shut down this discussion; but I do want to point out where we have discussed the very same questions before. The problem has been defining what distinguishes an 'assay' from an 'observing process'. An example for the former being testing a blood sample for its glucose concentration. An example for the later being be counting birds in a habitat. It turns out to be very hard to define the boundary. So we ended up calling the general process 'assay'. If there is a general 'observing process' it needs to be clear how it is different from the current definition of 'assay' which is: 'A planned process with the objective to produce information about the material entity that is the evaluant, by physically examining it or its proxies'.

The purpose of this definition was to capture any data generation we have seen in biomedical sciences, but the 'bird counting' example always felt like it wasn't appropriately captured.

ddooley commented 2 years ago

I hear you, and indeed assay may be satisfactory because of its broadly scoped definition.

One thing I'm wondering in a devil's advocate kind of way about material entity being hard-wired into observation process/assay: What if I or an algorithm are looking for (observing) circles in an image. Do I have to change the vocabulary I'm using if I learn that the image (which is usually digital these days anyways) was simulated? Or can I keep my observation process language and its outputs, and just say the input was simulated? This kind of thing is also being done with synthetic population cohorts in order to answer real-world questions, e.g. with the SynthEco project: https://www.researchgate.net/publication/344475781

bpeters42 commented 2 years ago

Good points @ddooley . The purely data-driven process could be considered a data-transformation (e.g. image recognition). And if the initial image is generated from a real thing, the combined image generating and image recognition process could be an assay (e.g. detection of lesions in the lung using image detection on an X-Ray picture). But the image recognition part can also be run on simulated data. These kind of questions of where a assay starts and stops and if data transformations are part of it are one of the topics for the upcoming OBI workshop, and are part of @zhengj2007 session.

wdduncan commented 2 years ago

There is a lot of interesting discussion here about observation processes :)

@ddooley some comments about your proposed definition for observation:

ddooley commented 2 years ago

That paragraph, out of a paper being reviewed which is aimed at non BFO experts interested in food processing modelling, is defining a data structure semantic used in the paper, but it has needs for an ontology to meet too. Here's the context of some related terms, offered up in the spirit of "trial by fire!" (e.g. I'm wondering how not to be circular about defining characteristic without going BFO!).

  • A characteristic: a “characteristic”, “feature”, “quality”, “attribute” or “phenotype” are often used to describe an observable property of an object. In food science “quality” may be used as a value judgement of a product, like a “good quality” ripe peach. Within OBO, BFO uses “quality” rather than characteristic for an observable object property, and so we also frequently use that term and sense below.

  • A measure (aka measurement): a data item record of a categorical, numeric, or numeric and unit value. The unit may also reveal a dimension of the thing being measured, for example if unit is “gram” then a material entity is being measured for mass. Measures may be simulated or predicted, or subject to precision and accuracy, and may be the result of faulty or miscalibrated equipment. This paper takes the position that a measure does not include time, place, or sensor “aboutness” information.

  • An observation: An observation is a data item resulting from an invasive or ...

An observation data item requires a data structure to encompass the contextual information about the time and place etc. of a measure. A data set composed of these observations could adopt the characteristic values they have in common, for example, if all of a dataset’s observations were made at the same location, then that location can become a characteristic of what the dataset is about, and is inherited rather than repeated at the observation level.

Hopefully echoing natural language semantics, observation is being explored as a multi-component data structure which is able to have one or more measures as parts, a number of which can be about the context of the observation rather than just characteristics of the thing being measured.

This diagram visualizes some of these constructs at play (p.s. I don't claim that it is all OBO in paper): image