OBOFoundry / COB

An experimental ontology containing key terms from Open Biological and Biomedical Ontologies (OBO)
https://obofoundry.github.io/COB
Creative Commons Zero v1.0 Universal
35 stars 8 forks source link

Add "phenotype" to COB #225

Open matentzn opened 1 year ago

matentzn commented 1 year ago

fixes #123

Let the war begin.

wdduncan commented 1 year ago

Yes ... I imagine there will be a lot of back forth about this.

@matentzn Are you proposing that by making phenotype a top level class that a particular phenotype may be a characteristic, material entity, or process? This suggests to me that it would be better to define a phenotype of object property (which I mentioned here); e.g.:

addiehl commented 1 year ago

I'm not against the object property approach but I think the inverses should be used here (in a weakened form in some cases): Tourette syndrome sometimes associated with phenotype facial tics cancer associated with phenotype tumor (although perhaps cancer disease has basis in tumor might be better although this is a bit chicken and egg) rash sometimes associated with phenotype discoloration

matentzn commented 1 year ago

This class is intended to group the about 100,000 phenotype classes under UPHENO: https://ols.monarchinitiative.org/ontologies/upheno2/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FUPHENO_0001001&viewMode=PreferredRoots&siblings=false

wdduncan commented 1 year ago

@matentzn In UPHENO, phenotype is a type of quality.

image

Shouldn't it be the same in COB?

matentzn commented 1 year ago

Yes, this is really controversial, and should probably not be in Upheno..