Open beckyjackson opened 5 years ago
Currently, there is a mix of skos:exactMatch
and skos:closeMatch
in core to link to external terms. See https://github.com/rctauber/Experimental-OBO-Core/pull/6
We will use skos:exactMatch
for any external terms that are equivalent terms so that we can later add the equivalence axioms.
@cmungall Looking at the matches in the current core-edit.owl
file, I see:
Core Term | Exact Match | Exact Match Label |
---|---|---|
organism | MeSH:D009938 | Organizations |
organism | biotop:Organ | Organ |
organism | CCO:Organization | Organization |
organism | SIO:000012 | organization |
organization | OBI:0100026 | organism |
I think these are incorrect and should be removed. Maybe Organ can be moved as a skos:closeMatch
for 'gross anatomical part'...
Additionally, 'cell' has exactMatch
http://purl.obolibrary.org/obo/CL_0000000 - should this be skos:closeMatch
instead? The GO cell IRI is not included in the matches, perhaps this should be a close match as well?
I can redo without the stemming to avoid the junk.
Let's discuss how best to manage this moving forward next week
I thought we would be doing this manually? There are a bunch of ontologies that I don't even want to link to / consider in this. I guess a question is what the link is intended to mean: I was thinking it goes to existing terms that we have taken into account when writing definitions.
On Thu, Jul 25, 2019 at 6:33 AM Chris Mungall notifications@github.com wrote:
I can redo without the stemming to avoid the junk.
Let's discuss how best to manage this moving forward next week
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/Experimental-OBO-Core/issues/23?email_source=notifications&email_token=ADJX2IV33PZHJ5INKIDPAATQBGTQ7A5CNFSM4IBVKBO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2ZPMOI#issuecomment-515044921, or mute the thread https://github.com/notifications/unsubscribe-auth/ADJX2IQ2Y6CRQZX3OCIJE5DQBGTQ7ANCNFSM4IBVKBOQ .
-- Bjoern Peters Professor La Jolla Institute for Allergy and Immunology 9420 Athena Circle La Jolla, CA 92037, USA Tel: 858/752-6914 Fax: 858/752-6987 http://www.liai.org/pages/faculty-peters
Restating some of what was in the archived repo: https://github.com/rctauber/Experimental-OBO-Core/pull/6
There are at least three distinct use cases here, highest priority first:
For 1, these should obviously be manually curated. Becky has done a first pass in #28, and she lists some outstanding questions in that PR
For 2, I am happy to take on this. These should also be manually curated, and will go in a separate file. Not clear if logical axioms or skos is the most appropriate here.
For 3, this was merged in https://github.com/rctauber/Experimental-OBO-Core/pull/6. This is automatic since the whole point is to see where we have clashes. skos is an appropriate vocabulary for this.
From @cmungall