Added "device" - Githubissues

OBOFoundry / COB

An experimental ontology containing key terms from Open Biological and Biomedical Ontologies (OBO)

https://obofoundry.github.io/COB

Creative Commons Zero v1.0 Universal

35 stars 8 forks source link

Added "device" #232

Closed ddooley closed 1 year ago

ddooley commented 1 year ago

To address https://github.com/OBOFoundry/COB/issues/222 . Also added "has function" and "function of", understanding that ultimately they will be imported from RO.

Note domain of "has function" is an 'independent continuant' but COB doesn't have that so are we needing a disjunction of top-level terms to reflect comparable logic?

ddooley commented 1 year ago

I don't know why the cob-edit.owl diff is different. I'm using latest protege 5.6.1. Its coding outside of classes they are mentioned in. Maybe that's normal now?!

cmungall commented 1 year ago

We need to have this in the CONTRIBUTING.md but PRs like this should always have corresponding edits to cob-to-external

matentzn commented 1 year ago

[ ] @cmungall as per #222 there should not be an external mapping for this term.
[x] @ddooley can you rename the PR? it seems has function is NOT added
[X] I fixed the spurious diff
[X] Made a PR to #237

ddooley commented 1 year ago

I've renamed. Forgot that there was shift to using "has characteristic" rather than "has function".

cmungall commented 1 year ago

Go ahead and merge if this is a blocker but I think we need a new SOP for NTRs that replace OBO IDs

proposed here:

ddooley commented 1 year ago

Note that OBI's "device" term is currently specialized to scientific investigations: "A material entity that is designed to perform a function in a scientific investigation, but is not a reagent." so its not an equivalent to the COB device term. I recall OBI will reuse COB's term, and add subclasses for functional kinds of device.