OBOFoundry / OBOFoundry.github.io

Metadata and website for the Open Bio Ontologies Foundry Ontology Registry
http://obofoundry.org
Other
164 stars 201 forks source link

Proposal: Star-ranking system for ontologies #1217

Closed nataled closed 4 years ago

nataled commented 4 years ago

BACKGROUND: Strictly speaking, Foundry designation has one real purpose: to indicate which of the (possibly several) ontologies in a given domain should be the point of 'convergence' (that is, reference and reuse by other ontologies). That's it. The manual reviews were meant as a way of selecting these. That's it. Unfortunately, every time we discuss abolishing the distinction between Foundry and Library, the discussion centers around reviews and how many were done and how the process works, and misses the main point. Given the developments around streamlining and automating the review process, I think we need to return to the central question: Do we find any value in selecting specific ontologies as points of convergence? If the answer is "No" then by all means get rid of the distinction completely. If the answer is "Yes" then consider the following proposal:

Decouple Foundry designation from manual review status, except in certain cases (see below). The designation can be given right away to any ontology that covers a completely unique sub-domain (that is, one that doesn't have overlap with another ontology). We would need a consensus on which ontologies meet this criterion. Ontologies that do have overlap with one or more other ontologies will need to be manually selected to get the Foundry designation, and that selection process can include manual reviews. We can decide that such reviews must be done in tandem (that is, the two or more conflicting ontologies get reviewed at once), or we can decide that whichever ontology makes the request gets reviewed, with favorability points given for the decision to be engaged in the process. Any unreviewed ontology with the Foundry designation would have that designation revoked if another ontology within the same sub-domain appears.

The advantage of this approach is that it encourages some of the very things we want to encourage, such as development of non-overlapping ontologies, yet maintains the purpose of the Foundry distinction. I imagine there would be quite a lot of ontologies with this designation using this approach, thus minimizing the issue of "it looks bad not having so many ontologies with Foundry status". Manual reviews can still be performed as insurance against revoking Foundry status.

This proposal addresses how it looks to the outside world AND maintains one of the key reasons why the Foundry exists: "By joining the initiative, the authors of an ontology commit to working with other members to ensure that, for any particular domain, there is convergence on a single ontology." (quote is from the 2007 Foundry paper). Note that this proposal is not mutually exclusive with the idea of a new sortable column (which really doesn't help the "how it looks" issue, it just potentially hides it until the sort is done).

The question then becomes how to ensure that a 'bad' ontology doesn't get Foundry status. For this we should make use of the dashboard.

Gold star (filled) = unique scope confirmed + manually reviewed Gold star (empty) = unique scope confirmed + good dashboard rating Silver star (filled) = unique scope suspected + good dashboard rating Silver star (empty) = needs scope review + good dashboard rating No star = needs scope review + poor dashboard rating

Current 'Foundry' status would be gold-filled. All others would be silver-empty if the dashboard indicates its okay (we'd have to decide what that means--should make a separate ticket if this proposal is accepted in principle). Cursory looks would reveal which silver-empty should get filled.

mellybelly commented 4 years ago

My understanding from days of old (dating back to the 2006 F2F in UK) was that the Foundry status indicated that an ontology had been through the review process and had "passed". I am not aware of it being an indication of convergence; in my view that would require computational and content evaluations that have not been done much to my knowledge.

In our current implementation, I think the Foundry status does OBO a disservice. I hear regularly that when people go to the OBO site they only see a few "good" or "community endorsed" ontologies. Of course there are many good ontologies in OBO that have been extensively published upon, reviewed elsewhere, and are in wide use, but are have not been through the OBO review and so do not have Foundry status.

I do believe there should be an effort to have a point of convergence (the principle of orthogonality), but I also believe there should be some flexibility to model overlapping domains in different ways. We just approved the PURL for the Ontology for Nutritional Studies #1198 and prior to that we had our MaXO ontology approved, which has nutritional interventions - there is most definitely overlapping content conceptually, but it is modeled differently. There is also the challenge of determining what is an "application ontology" versus what is canonical and what would be allowed in that context. There are things to consider with resources that "come from outside" or that have been around longer than OBO, such as NCBItaxon, or NCIt (for which we worked hard to get a CC-BY license and to develop OBO axioms for) due to its extensive use and potential for improved translational computation as well as covering a domain not well covered in OBO already.

I personally would vote no on having Foundry status be "points of convergence" because there are not the governance processes nor the criteria in place to determine such things at this time, nor do I see what value it would bring. We can certainly work on governance and on orthogonality and alignment of modeling, but any such determination would likely be a subjective one at this time. I do think the dashboard checks are AWESOME and am excited to see this evolve- this i do find very useful.

To me, joining the OBO library, getting your OBO PURL, and participating in community processes and reusing ontologies from across the OBO community is what makes OBO valuable, including a dedication to adherence to our founding principles. I do not believe we need an additional distinction of "Foundry" nor do i believe we have the computational criteria nor governance structures in place for fairly determining such things.

Finally, I think the goals of OBO should be interoperability, computability, and reuse, and I don't see where a separate Foundry distinction helps us achieve that.

wdduncan commented 4 years ago

I agree with @mellybelly on many points.

there are many good ontologies in OBO that have been extensively published upon, reviewed elsewhere, and are in wide use, but are have not been through the OBO review and so do not have Foundry status.

Yes. UBERON, Envo, Mondo, HP are widely used, but are not official "Foundry ontologies" (although UBERON and Envo are currently under review). Also, the manual review process seems overly impractical to implement consistently. This includes finding competent domain-knowledge reviewers as well as ontologists who can spot problems in the hierarchy (e.g., having a process listed under a quality). For example, in the disease ontology, ovarian cancer is defined using the axiom cancer and ('located in' some ovary). Since the DO takes the dispositional view of disease (see its textual definition for 'disease'), this is clearly ontologically incorrect: dispositions are not "located in" (see definition for 'located in') other entities.

My intent is not to attack the DO (sorry if it sounds like that), but only to point out the lack of understanding of what is needed to "pass" a manual review. To me, as an ontologist, I would have not approved the DO. I would have said there is a lot of great content in it, but there are some fundamental problems with it (from an ontological perspective) that need to be fixed before it can pass muster.

So what is the standard that needs to be applied for review? In an ideal world, both content and ontological rigor should be applied. But we are a volunteer organization with limited time and resources. Also, does a Foundry ontology need to be re-reviewed on periodic basis? It could be the case that the version of the DO that was reviewed did not contain ontological inconsistencies, but now it does. Should its "Foundry" status be downgraded? Who has the bandwidth to regularly check-up on the status of Foundry ontologies? IMHO, these impracticalities just make it seem best to drop the manually reviewed distinction.

nor do i believe we have the computational criteria nor governance structures in place for fairly determining such things.

Yes ... but we working on tools. The robot report is a great start. Some other ideas I have that might help with the computational aspect of things include:

The goal these reports, in my mind, is to provide other developers a quicker way to assess the applicability of the OBO ontology to their domain of interest. It would allow us (I hope) to assess ontology orthoginality.

Perhaps this information could also lead to some kind of "OBO score", but I am wary to go down that path right now until we decide the role of manual reviews.

nataled commented 4 years ago

@mellybelly @wdduncan I was asked to open this ticket as a means to discuss a specific proposal on how to deal with the perception that the Foundry has only a few ontologies. The proposal specifically grants Foundry status to many ontologies (unclear to me why this fact is lost upon reading). In any case, as the discussion here is not about the proposal, but is instead about the ticket (#1140) from which this was grabbed, I am closing this ticket until there is agreement on whether or not Foundry distinction is useful.

lschriml commented 4 years ago

Hello @wdduncan, I appreciate your insights. I am always looking for ways to improve the DO.

As we chatted about on the call today. The definition of disease was founded on group discussions with Alan and Barry. You may have noticed that we site their 2009 paper, which includes: The approach we recommend rests on an account of diseases as dispositions rooted in physical disorders in the organism and realized in pathological processes.

which defines disposition as: A disposition is an attribute of an organism in virtue of which it will initiate certain specific sorts of processes when certain conditions are satisfied

As the DO has not integrated the BFO, do you still see this as a conflict that our disease definition includes the word 'disposition' ?

Regarding 'located_in' relation.

In OntoBee located_in: example of usage: this rat is located in this cage; my brain is located in my head

In the early days of the DO, Barry and our scientific advisory board members reviewed and approved our Relation usage.

At that time, the definition of : located_in --> was based on the RO 2005 publication: located_in r at t - a primitive relation between a continuant instance, a spatial region which it occupies, and a time

Although the RO has evolved and the definition revised, I think our usage of located_in still fits with the example 'this rat is located in this cage'

'located_in' has been used in this way across other ontologies, to denote the location of disease in the human body.

In IDO for example: bacteremia equivalentClass : infection and ( has part some ( infectious agent and Bacteria and ( located in some blood)))

Ontology of Host Pathogen Interactions viremia subClassOf : has part some ( infectious agent and Viruses and ( located in some blood))

Cheers, Lynn

alanruttenberg commented 4 years ago

On Sat, May 30, 2020 at 7:05 PM Melissa Haendel notifications@github.com wrote:

My understanding from days of old (dating back to the 2006 F2F in UK) was that the Foundry status indicated that an ontology had been through the review process and had "passed". I am not aware of it being an indication of convergence; in my view that would require computational and content evaluations that have not been done much to my knowledge.

Yes. There was also the idea that foundry ontologies were the selected ontologies for a given domain, although it was understood that we were always open to upstarts doing a better job. That's my understanding of what is being talked about as "convergence". But maybe I misunderstand.

In our current implementation, I think the Foundry status does OBO a disservice. I hear regularly that when people go to the OBO site they only see a few "good" or "community endorsed" ontologies. Of course there are many good ontologies in OBO that have been extensively published upon, reviewed elsewhere, and are in wide use, but are have not been through the OBO review and so do not have Foundry status.

I agree that the foundry status has not achieved the goals that were initially intended, and that currently they are misleading. So I concur that it should be abandoned unless made more rigorous.

I do believe there should be an effort to have a point of convergence (the principle of orthogonality), but I also believe there should be some flexibility to model overlapping domains in different ways. We just approved the PURL for the Ontology for Nutritional Studies #1198 https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1198

I think that the goal is, and should remain, that there should not be two terms that have the same denotation - the same set of individuals. However even in BFO's origin the notion of perspectival views was prominent with the SNAP/SPAN distinction. One has to tread carefully here, however, as each time there are different perspectives there's work to do to relate the perspectives as well as is possible, and if we're not careful then we have two ways of saying the same thing which hurts interoperabilty.

and prior to that we had our MaXO ontology approved, which has nutritional interventions - there is most definitely overlapping content conceptually, but it is modeled differently. There is also the challenge of determining what is an "application ontology" versus what is canonical and what would be allowed in that context.

I thought that was relatively straightforward (application ontology). It's one that only uses terms from reference ontologies or terms which are completely defined in terms of reference ontologies. Or terms that are specific to operation of a single application.

There are things to consider with resources that "come from outside" or that have been around longer than OBO, such as NCBItaxon, or NCIt (for which we worked hard to get a CC-BY license and to develop OBO axioms for) due to its extensive use and potential for improved translational computation as well as covering a domain not well covered in OBO already.

I personally would vote no on having Foundry status be "points of convergence" because there are not the governance processes nor the criteria in place to determine such things at this time, nor do I see what value it would bring.

It brings value to clients. It's very confusing to have to choose between different ontologies from the same domain and it's damaging (for interoperability) when different choices are made. So in the ideal case we are supporting that. However, as you say, we do need to firm up processes around that.

We can certainly work on governance and on orthogonality and alignment of modeling, but any such determination would likely be a subjective one at this time. I do think the dashboard checks are AWESOME and am excited to see this evolve- this i do find very useful.

To me, joining the OBO library, getting your OBO PURL, and participating in community processes and reusing ontologies from across the OBO community is what makes OBO valuable, including a dedication to adherence to our founding principles. I do not believe we need an additional distinction of "Foundry" nor do i believe we have the computational criteria nor governance structures in place for fairly determining such things.

Agreed on Foundry. But I think we should be striving for policies that support convergence, under some other banner.

Finally, I think the goals of OBO should be interoperability, computability, and reuse, and I don't see where a separate Foundry distinction helps us achieve that.

In principle it was aimed particularly at interoperability and reuse. I think it's done some in those directions, but not enough. Alan

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-636396121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3CDTBMSLBWGRGPYVL5TTRUGGKLANCNFSM4NFFVBAA .

alanruttenberg commented 4 years ago

On Tue, Jun 2, 2020 at 4:47 PM lschriml notifications@github.com wrote:

Hello @wdduncan https://github.com/wdduncan, I appreciate your insights. I am always looking for ways to improve the DO.

As we chatted about on the call today. The definition of disease was founded on group discussions with Alan and Barry. You may have noticed that we site their 2009 paper, which includes: The approach we recommend rests on an account of diseases as dispositions rooted in physical disorders in the organism and realized in pathological processes.

which defines disposition as: A disposition is an attribute of an organism in virtue of which it will initiate certain specific sorts of processes when certain conditions are satisfied

As the DO has not integrated the BFO, do you still see this as a conflict that our disease definition includes the word 'disposition' ?

I think it is misleading. OGMS sets out a principled approach to disease representation. I have opined that DO should be organized as OGMS is, as has Barry. Minimally it should avoid using the term if it doesn't mean what BFO means.

Regarding 'located_in' relation.

In OntoBee http://www.ontobee.org/ontology/ODAE?iri=http://purl.obolibrary.org/obo/RO_0001025 located_in: example of usage: this rat is located in this cage; my brain is located in my head

In the early days of the DO, Barry and our scientific advisory board members reviewed and approved our Relation usage.

At that time, the definition of : located_in --> was based on the RO 2005 publication: located_in r at t - a primitive relation between a continuant instance, a spatial region which it occupies, and a time

Although the RO has evolved and the definition revised, I think our usage of located_in still fits with the example 'this rat is located in this cage'

'located_in' has been used in this way across other ontologies, to denote the location of disease in the human body.

In OGMS the idea is that the material basis of the disposition is the thing that is located. BFO relates only independent continuants (on the continuant side) to spatial regions.

In IDO for example: bacteremia equivalentClass : infection and ( has part some ( infectious agent and Bacteria and ( located in some blood)))

All of the terms therein are material entities, not dispositions. Those terms in turn may be related to dispositions.

Ontology of Host Pathogen Interactions viremia subClassOf : has part some ( infectious agent and Viruses and ( located in some blood))

From OGMS point of view, bacteremia and viremia is a disorder, a material entity. The definition is consistent with that. Regards, Alan

Cheers, Lynn

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-637796924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3CDQMQYMD37CWPDDWOJ3RUVQN5ANCNFSM4NFFVBAA .

lschriml commented 4 years ago

Hello Alan, Thank you for the clarification. I see what you mean. The DO includes both independent and dependent continuents. It had been my intent to have DO's usage of disposition to be the same as OGMS. I see from reading through OGMS definitions, that our alignment is not as tight as it originally was. I will revisit our DO disease definition.

Does OGMS relate specifically dependent continuents to spatial regions ?

Cheers, Lynn

On Thu, Jun 4, 2020 at 2:11 PM Alan Ruttenberg notifications@github.com wrote:

On Tue, Jun 2, 2020 at 4:47 PM lschriml notifications@github.com wrote:

Hello @wdduncan https://github.com/wdduncan, I appreciate your insights. I am always looking for ways to improve the DO.

As we chatted about on the call today. The definition of disease was founded on group discussions with Alan and Barry. You may have noticed that we site their 2009 paper, which includes: The approach we recommend rests on an account of diseases as dispositions rooted in physical disorders in the organism and realized in pathological processes.

which defines disposition as: A disposition is an attribute of an organism in virtue of which it will initiate certain specific sorts of processes when certain conditions are satisfied

As the DO has not integrated the BFO, do you still see this as a conflict that our disease definition includes the word 'disposition' ?

I think it is misleading. OGMS sets out a principled approach to disease representation. I have opined that DO should be organized as OGMS is, as has Barry. Minimally it should avoid using the term if it doesn't mean what BFO means.

Regarding 'located_in' relation.

In OntoBee < http://www.ontobee.org/ontology/ODAE?iri=http://purl.obolibrary.org/obo/RO_0001025

located_in: example of usage: this rat is located in this cage; my brain is located in my head

In the early days of the DO, Barry and our scientific advisory board members reviewed and approved our Relation usage.

At that time, the definition of : located_in --> was based on the RO 2005 publication: located_in r at t - a primitive relation between a continuant instance, a spatial region which it occupies, and a time

Although the RO has evolved and the definition revised, I think our usage of located_in still fits with the example 'this rat is located in this cage'

'located_in' has been used in this way across other ontologies, to denote the location of disease in the human body.

In OGMS the idea is that the material basis of the disposition is the thing that is located. BFO relates only independent continuants (on the continuant side) to spatial regions.

In IDO for example: bacteremia equivalentClass : infection and ( has part some ( infectious agent and Bacteria and ( located in some blood)))

All of the terms therein are material entities, not dispositions. Those terms in turn may be related to dispositions.

Ontology of Host Pathogen Interactions viremia subClassOf : has part some ( infectious agent and Viruses and ( located in some blood))

From OGMS point of view, bacteremia and viremia is a disorder, a material entity. The definition is consistent with that. Regards, Alan

Cheers, Lynn

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-637796924 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAB3CDQMQYMD37CWPDDWOJ3RUVQN5ANCNFSM4NFFVBAA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639019018, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBB4DKL3SGAAJGPS3Q6ZXLRU7PWJANCNFSM4NFFVBAA .

-- Lynn M. Schriml, Ph.D. Associate Professor

Institute for Genome Sciences University of Maryland School of Medicine Department of Epidemiology and Public Health 670 W. Baltimore St., HSFIII, Room 3061 Baltimore, MD 21201 P: 410-706-6776 | F: 410-706-6756 lschriml@som.umaryland.edu

alanruttenberg commented 4 years ago

On Thu, Jun 4, 2020 at 2:43 PM lschriml notifications@github.com wrote:

Hello Alan, Thank you for the clarification. I see what you mean. The DO includes both independent and dependent continuents. It had been my intent to have DO's usage of disposition to be the same as OGMS. I see from reading through OGMS definitions, that our alignment is not as tight as it originally was. I will revisit our DO disease definition.

Does OGMS relate specifically dependent continuents to spatial regions ?

Unlikely. More typical would be to use the relation that locates one continuant in another.

The names have been confusing in the past (I think there was located_in and located_at) and we tried to make them clearer in BFO 2020.

The relation between continuants is located_in. For example, blood vessel located_in body (at a time).

There's an analogous relation for a process and a continuant called occurs_in.

The relation from continuant to spatial region is called occupies_spatial_region. But as I said this is rarely used in biology. More typical would be to use located_in to a site. For example stomach acid located_in stomach cavity.

I just checked OGMS and it doesn't use any relations currently. It would be more typical that a disease ontology that is based on OGMS (like IDO) would use the relations, since OGMS is relatively high level.

The relation has_material_basis is defined in BFO 2020.

Regards, Alan

Cheers, Lynn

On Thu, Jun 4, 2020 at 2:11 PM Alan Ruttenberg notifications@github.com wrote:

On Tue, Jun 2, 2020 at 4:47 PM lschriml notifications@github.com wrote:

Hello @wdduncan https://github.com/wdduncan, I appreciate your insights. I am always looking for ways to improve the DO.

As we chatted about on the call today. The definition of disease was founded on group discussions with Alan and Barry. You may have noticed that we site their 2009 paper, which includes: The approach we recommend rests on an account of diseases as dispositions rooted in physical disorders in the organism and realized in pathological processes.

which defines disposition as: A disposition is an attribute of an organism in virtue of which it will initiate certain specific sorts of processes when certain conditions are satisfied

As the DO has not integrated the BFO, do you still see this as a conflict that our disease definition includes the word 'disposition' ?

I think it is misleading. OGMS sets out a principled approach to disease representation. I have opined that DO should be organized as OGMS is, as has Barry. Minimally it should avoid using the term if it doesn't mean what BFO means.

Regarding 'located_in' relation.

In OntoBee <

http://www.ontobee.org/ontology/ODAE?iri=http://purl.obolibrary.org/obo/RO_0001025

located_in: example of usage: this rat is located in this cage; my brain is located in my head

In the early days of the DO, Barry and our scientific advisory board members reviewed and approved our Relation usage.

At that time, the definition of : located_in --> was based on the RO 2005 publication: located_in r at t - a primitive relation between a continuant instance, a spatial region which it occupies, and a time

Although the RO has evolved and the definition revised, I think our usage of located_in still fits with the example 'this rat is located in this cage'

'located_in' has been used in this way across other ontologies, to denote the location of disease in the human body.

In OGMS the idea is that the material basis of the disposition is the thing that is located. BFO relates only independent continuants (on the continuant side) to spatial regions.

In IDO for example: bacteremia equivalentClass : infection and ( has part some ( infectious agent and Bacteria and ( located in some blood)))

All of the terms therein are material entities, not dispositions. Those terms in turn may be related to dispositions.

Ontology of Host Pathogen Interactions viremia subClassOf : has part some ( infectious agent and Viruses and ( located in some blood))

From OGMS point of view, bacteremia and viremia is a disorder, a material entity. The definition is consistent with that. Regards, Alan

Cheers, Lynn

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <

https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-637796924

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAB3CDQMQYMD37CWPDDWOJ3RUVQN5ANCNFSM4NFFVBAA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639019018 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABBB4DKL3SGAAJGPS3Q6ZXLRU7PWJANCNFSM4NFFVBAA

.

-- Lynn M. Schriml, Ph.D. Associate Professor

Institute for Genome Sciences University of Maryland School of Medicine Department of Epidemiology and Public Health 670 W. Baltimore St., HSFIII, Room 3061 Baltimore, MD 21201 P: 410-706-6776 | F: 410-706-6756 lschriml@som.umaryland.edu

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639044064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB3CDTXOPSOQIL2LTIZX63RU7TM5ANCNFSM4NFFVBAA .

lschriml commented 4 years ago

Thank you Alan, This is very helpful !!

Cheers, Lynn

On Thu, Jun 4, 2020 at 3:34 PM Alan Ruttenberg notifications@github.com wrote:

On Thu, Jun 4, 2020 at 2:43 PM lschriml notifications@github.com wrote:

Hello Alan, Thank you for the clarification. I see what you mean. The DO includes both independent and dependent continuents. It had been my intent to have DO's usage of disposition to be the same as OGMS. I see from reading through OGMS definitions, that our alignment is not as tight as it originally was. I will revisit our DO disease definition.

Does OGMS relate specifically dependent continuents to spatial regions ?

Unlikely. More typical would be to use the relation that locates one continuant in another.

The names have been confusing in the past (I think there was located_in and located_at) and we tried to make them clearer in BFO 2020.

The relation between continuants is located_in. For example, blood vessel located_in body (at a time).

There's an analogous relation for a process and a continuant called occurs_in.

The relation from continuant to spatial region is called occupies_spatial_region. But as I said this is rarely used in biology. More typical would be to use located_in to a site. For example stomach acid located_in stomach cavity.

I just checked OGMS and it doesn't use any relations currently. It would be more typical that a disease ontology that is based on OGMS (like IDO) would use the relations, since OGMS is relatively high level.

The relation has_material_basis is defined in BFO 2020.

Regards, Alan

Cheers, Lynn

On Thu, Jun 4, 2020 at 2:11 PM Alan Ruttenberg <notifications@github.com

wrote:

On Tue, Jun 2, 2020 at 4:47 PM lschriml notifications@github.com wrote:

Hello @wdduncan https://github.com/wdduncan, I appreciate your insights. I am always looking for ways to improve the DO.

As we chatted about on the call today. The definition of disease was founded on group discussions with Alan and Barry. You may have noticed that we site their 2009 paper, which includes: The approach we recommend rests on an account of diseases as dispositions rooted in physical disorders in the organism and realized in pathological processes.

which defines disposition as: A disposition is an attribute of an organism in virtue of which it will initiate certain specific sorts of processes when certain conditions are satisfied

As the DO has not integrated the BFO, do you still see this as a conflict that our disease definition includes the word 'disposition' ?

I think it is misleading. OGMS sets out a principled approach to disease representation. I have opined that DO should be organized as OGMS is, as has Barry. Minimally it should avoid using the term if it doesn't mean what BFO means.

Regarding 'located_in' relation.

In OntoBee <

http://www.ontobee.org/ontology/ODAE?iri=http://purl.obolibrary.org/obo/RO_0001025

located_in: example of usage: this rat is located in this cage; my brain is located in my head

In the early days of the DO, Barry and our scientific advisory board members reviewed and approved our Relation usage.

At that time, the definition of : located_in --> was based on the RO 2005 publication: located_in r at t - a primitive relation between a continuant instance, a spatial region which it occupies, and a time

Although the RO has evolved and the definition revised, I think our usage of located_in still fits with the example 'this rat is located in this cage'

'located_in' has been used in this way across other ontologies, to denote the location of disease in the human body.

In OGMS the idea is that the material basis of the disposition is the thing that is located. BFO relates only independent continuants (on the continuant side) to spatial regions.

In IDO for example: bacteremia equivalentClass : infection and ( has part some ( infectious agent and Bacteria and ( located in some blood)))

All of the terms therein are material entities, not dispositions. Those terms in turn may be related to dispositions.

Ontology of Host Pathogen Interactions viremia subClassOf : has part some ( infectious agent and Viruses and ( located in some blood))

From OGMS point of view, bacteremia and viremia is a disorder, a material entity. The definition is consistent with that. Regards, Alan

Cheers, Lynn

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <

https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-637796924

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAB3CDQMQYMD37CWPDDWOJ3RUVQN5ANCNFSM4NFFVBAA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639019018

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABBB4DKL3SGAAJGPS3Q6ZXLRU7PWJANCNFSM4NFFVBAA

.

-- Lynn M. Schriml, Ph.D. Associate Professor

Institute for Genome Sciences University of Maryland School of Medicine Department of Epidemiology and Public Health 670 W. Baltimore St., HSFIII, Room 3061 Baltimore, MD 21201 P: 410-706-6776 | F: 410-706-6756 lschriml@som.umaryland.edu

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639044064 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAB3CDTXOPSOQIL2LTIZX63RU7TM5ANCNFSM4NFFVBAA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/1217#issuecomment-639071897, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBB4DKAVRK6H2RKRRA6XJTRU7ZNFANCNFSM4NFFVBAA .

-- Lynn M. Schriml, Ph.D. Associate Professor

Institute for Genome Sciences University of Maryland School of Medicine Department of Epidemiology and Public Health 670 W. Baltimore St., HSFIII, Room 3061 Baltimore, MD 21201 P: 410-706-6776 | F: 410-706-6756 lschriml@som.umaryland.edu