Closed cthoyt closed 2 years ago
The specific example for EPSO was fixed in https://github.com/OBOFoundry/OBOFoundry.github.io/commit/ef6aa8d4ea34421cb2b4b1e26e1a63456365d1f2, but this issue shouldn't be closed until there's a technical solution to guard against this in the future (e.g., implementing a new test run in CI that fails when appropriate)
Yep we need a check
Could be trivially added to #1661.
No, it did not. I am still unsure how we will go about implementing new tests outside of the existing framework. Also, #1661 was merged into another branch that is the subject of another PR, not the main branch.
Isnt there some thing in json schema to specify all lowercase?
A regex would work
@cthoyt this seems like the sort of thing that you could do a PR for and then it'd be done...
Weird, there already is a check:
https://github.com/OBOFoundry/OBOFoundry.github.io/blob/master/util/schema/registry_schema.json#L142
Trying now: https://github.com/OBOFoundry/OBOFoundry.github.io/pull/1818
Doesnt work the error was spurious. Any idea?
No idea, let's close this one, since some other improvements to the testing pipeline in the mean time might have fixed it
While the preferred prefix can have mixed case, it seems that the
id
field for all OBO Foundry ontologies, even including ones with uppercase or mixed case preferred prefixes have been completely lowercased. The current testing suite does not check for this, and the merge of https://github.com/OBOFoundry/OBOFoundry.github.io/pull/1646 is the first example where theid
was uppercase.I noticed this because it broke the Bioregistry build, which assumed that the ID fields would be lowercase.